[GitHub] spark pull request: [SPARK-14295][SPARK-14274][SQL] Implements bui...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12088#discussion_r58147060
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMRelation.scala ---
    @@ -127,6 +135,25 @@ class DefaultSource extends FileFormat with DataSourceRegister {
             StructField("features", new VectorUDT(), nullable = false) :: Nil))
       }
     
    +  override def prepareRead(
    +      sqlContext: SQLContext,
    +      options: Map[String, String],
    +      files: Seq[FileStatus]): Map[String, String] = {
    +    def computeNumFeatures(): Int = {
    --- End diff --
    
    How about just put the method body into the getOrElse block?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org