[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29756: Adding sorting keys to generate_pages

["amoghrajesh (via GitHub)" <gi...@apache.org>]

amoghrajesh commented on code in PR #29756:
URL: https://github.com/apache/airflow/pull/29756#discussion_r1117942284


##########
airflow/www/utils.py:
##########
@@ -219,7 +219,16 @@ def get_params(**kwargs):
     return urlencode({d: v for d, v in kwargs.items() if v is not None}, True)
 
 
-def generate_pages(current_page, num_of_pages, search=None, status=None, tags=None, window=7):
+def generate_pages(
+    current_page,
+    num_of_pages,
+    search=None,
+    status=None,
+    tags=None,
+    window=7,
+    sorting_key=None,
+    sorting_direction=None,

Review Comment:
   Thanks. Adding it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org