[GitHub] [incubator-sdap-nexus] skorper commented on a change in pull request #126: CDMS-50: Updated matchup algorithm to remove parameter restriction

[GitBox <gi...@apache.org>]

skorper commented on a change in pull request #126:
URL: https://github.com/apache/incubator-sdap-nexus/pull/126#discussion_r609998182



##########
File path: analysis/webservice/algorithms_spark/Matchup.py
##########
@@ -356,11 +356,11 @@ def from_nexus_point(nexus_point, tile=None, parameter='sst'):
         point.data_id = "%s[%s]" % (tile.tile_id, nexus_point.index)
 
         # TODO Not an ideal solution; but it works for now.
-        if parameter == 'sst':
+        if parameter == 'sst' or parameter == None:
             point.sst = nexus_point.data_val.item()
-        elif parameter == 'sss':
+        if parameter == 'sss' or parameter == None:
             point.sss = nexus_point.data_val.item()
-        elif parameter == 'wind':
+        if parameter == 'wind' or parameter == None:
             point.wind_u = nexus_point.data_val.item()

Review comment:
       You're right, I hadn't noticed the values were the same for sst, sss, and wind. I'll continue working this ticket, thanks for your review @ngachung 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org