[jira] [Commented] (OAK-4373) Refactor SegmentTracker

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296340#comment-15296340 ] 

Michael Dürig commented on OAK-4373:
------------------------------------

Initial set of changes at http://svn.apache.org/viewvc?rev=1745182&view=rev. With this {{SegmentTracker}} is back to its original purpose, which is tracking segment ids. The additional functionality it accumulated over time moved elsewhere:
* There is now a {{SegmentReader}}, who owns the read specific caches (for now this is the string cache but I figure the template cache should also go there). 
* {{SegmentReader}}, {{SegmentWriter}} and {{SegmentTracker}} can now be acquired from {{SegmentStore}} and that one is passed around as needed. This should be regarded as an intermediate step. As {{SegmentStore}} is now overloaded I plan to rip it apart into individual concerns in follow up commits. 


> Refactor SegmentTracker
> -----------------------
>
>                 Key: OAK-4373
>                 URL: https://issues.apache.org/jira/browse/OAK-4373
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: technical_debt
>             Fix For: 1.6
>
>
> The {{SegmentTracker}} class has become the dumping ground for everything that wouldn't fit else where. In a personal discussion with [~frm], we figured that this class might be a good starting point refactoring {{segment-tar}} towards better encapsulation. 
> The aim would be to return {{SegmentTracker}} to its initial purpose (i.e. tracking segments) and move all unrelated concerns elsewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)