[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10358: Clean up the Block APIs

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10358:
URL: https://github.com/apache/pinot/pull/10358#discussion_r1122167077


##########
pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java:
##########
@@ -29,4 +41,41 @@ public interface BlockDocIdSet {
    * ascending order.
    */
   BlockDocIdIterator iterator();
+
+  /**
+   * Returns the number of entries (SV value contains one entry, MV value contains multiple entries) scanned in the
+   * filtering phase. This method should be called after the filtering is done.
+   */
+  long getNumEntriesScannedInFilter();
+
+  /**
+   * For scan-based FilterBlockDocIdSet, pre-scans the documents and returns a non-scan-based FilterBlockDocIdSet.
+   */
+  default BlockDocIdSet toNonScanDocIdSet() {

Review Comment:
   I kind of prefer the current name (carried from the existing code) since we have scan-based and non-scan-based iterator, and we want to convert the scan-based one to non-scan-based



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org