You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Jake Mannix (JIRA)" <ji...@apache.org> on 2013/04/05 20:13:15 UTC
[jira] [Commented] (MAHOUT-1186) OpenKeyTypeObjectHashMap#clear()
has been broken forever.
[ https://issues.apache.org/jira/browse/MAHOUT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623885#comment-13623885 ]
Jake Mannix commented on MAHOUT-1186:
-------------------------------------
Thanks for catching this, Andy. Slipped by the unit test because we were a) only checking size() == 0, and b) this only happens if the item added happens to land in the last bucket of the backing array. Sneaky!
> OpenKeyTypeObjectHashMap#clear() has been broken forever.
> ---------------------------------------------------------
>
> Key: MAHOUT-1186
> URL: https://issues.apache.org/jira/browse/MAHOUT-1186
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.3, collections-1.0
> Reporter: Andy Schlaikjer
> Assignee: Jake Mannix
> Fix For: 0.8
>
> Attachments: MAHOUT-1186.diff
>
>
> Arrays.clear(array, 0, array.length - 1, FREE);
> Means that the last entry in the array is *not* FREE, and hence arrays.clear only *sometimes* empties the array, and hence only *sometimes* clears out all of the entries in the map. Other times, it leaves one element behind. :(
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira