You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/30 13:32:09 UTC
[GitHub] [flink] AHeise opened a new pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
AHeise opened a new pull request #13031:
URL: https://github.com/apache/flink/pull/13031
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Enables parallel user-code and plugin class loader.
## Brief change log
- Mark class loaders as parallel usable.
- Adjust locking in user class loaders (plugin already used the appropriate method).
## Verifying this change
No new test (test ideas welcome), covered by all IT and e2e tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13031:
URL: https://github.com/apache/flink/pull/13031#issuecomment-666378800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057",
"triggerID" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda9fa6842aa8a78d0868d9946bd90077d3af3fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13031:
URL: https://github.com/apache/flink/pull/13031#discussion_r466864583
##########
File path: flink-core/src/main/java/org/apache/flink/util/ChildFirstClassLoader.java
##########
@@ -73,9 +71,7 @@ public ChildFirstClassLoader(
// let URLClassLoader do it, which will eventually call the parent
c = super.loadClassWithoutExceptionHandling(name, resolve);
}
- }
-
- if (resolve) {
+ } else if (resolve) {
Review comment:
what's this change about?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #13031:
URL: https://github.com/apache/flink/pull/13031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13031:
URL: https://github.com/apache/flink/pull/13031#issuecomment-666378800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057",
"triggerID" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"triggerType" : "PUSH"
}, {
"hash" : "a1e53c3791bde520ed9fa53d188fb1420d751fa3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1e53c3791bde520ed9fa53d188fb1420d751fa3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda9fa6842aa8a78d0868d9946bd90077d3af3fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057)
* a1e53c3791bde520ed9fa53d188fb1420d751fa3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13031:
URL: https://github.com/apache/flink/pull/13031#issuecomment-666367688
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit eda9fa6842aa8a78d0868d9946bd90077d3af3fb (Thu Jul 30 13:34:00 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13031:
URL: https://github.com/apache/flink/pull/13031#issuecomment-666378800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057",
"triggerID" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda9fa6842aa8a78d0868d9946bd90077d3af3fb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13031:
URL: https://github.com/apache/flink/pull/13031#issuecomment-666378800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda9fa6842aa8a78d0868d9946bd90077d3af3fb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13031:
URL: https://github.com/apache/flink/pull/13031#issuecomment-666378800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057",
"triggerID" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"triggerType" : "PUSH"
}, {
"hash" : "a1e53c3791bde520ed9fa53d188fb1420d751fa3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5293",
"triggerID" : "a1e53c3791bde520ed9fa53d188fb1420d751fa3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1e53c3791bde520ed9fa53d188fb1420d751fa3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13031:
URL: https://github.com/apache/flink/pull/13031#issuecomment-666378800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057",
"triggerID" : "eda9fa6842aa8a78d0868d9946bd90077d3af3fb",
"triggerType" : "PUSH"
}, {
"hash" : "a1e53c3791bde520ed9fa53d188fb1420d751fa3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5293",
"triggerID" : "a1e53c3791bde520ed9fa53d188fb1420d751fa3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda9fa6842aa8a78d0868d9946bd90077d3af3fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5057)
* a1e53c3791bde520ed9fa53d188fb1420d751fa3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13031:
URL: https://github.com/apache/flink/pull/13031#discussion_r466998507
##########
File path: flink-core/src/main/java/org/apache/flink/util/ChildFirstClassLoader.java
##########
@@ -73,9 +71,7 @@ public ChildFirstClassLoader(
// let URLClassLoader do it, which will eventually call the parent
c = super.loadClassWithoutExceptionHandling(name, resolve);
}
- }
-
- if (resolve) {
+ } else if (resolve) {
Review comment:
Ok that makes sense, let's move it into another commit and then we're good to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #13031: [FLINK-18773][runtime] Enables parallel user-code and plugin class loader.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #13031:
URL: https://github.com/apache/flink/pull/13031#discussion_r466992670
##########
File path: flink-core/src/main/java/org/apache/flink/util/ChildFirstClassLoader.java
##########
@@ -73,9 +71,7 @@ public ChildFirstClassLoader(
// let URLClassLoader do it, which will eventually call the parent
c = super.loadClassWithoutExceptionHandling(name, resolve);
}
- }
-
- if (resolve) {
+ } else if (resolve) {
Review comment:
It's a small performance optimization (should probably go in a separate hotfix commit). The typical class loading pattern indeed has this trailing resolution with an if, but in `ChildFirstClassLoader`, the resolution already happens at `super.loadClassWithoutExceptionHandling(name, resolve)`. So it should never be necessary to resolve it additionally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org