You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2016/03/14 17:03:23 UTC
[GitHub] couchdb-couch pull request: Fix incorrect use of eunit fixtures
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/151
Fix incorrect use of eunit fixtures
The tests were over-wrapped. We should return simple tests from every test case. Otherwise the tests would always pass since `eunit` wouldn't execute the test body when `?_` used in this context.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch fix_db_plugin_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #151
----
commit 9ca620582a9728a87518dfcffd5665bfb174eead
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2016-03-14T15:58:33Z
Fix incorrect use of eunit fixtures
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Fix incorrect use of eunit fixtures
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Fix incorrect use of eunit fixtures
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/151#issuecomment-196922735
Oh, missed this one in the notifications. Test was tested, looks good : +1
On a side note - why do you prefer `?assertMatch` over `?assertEqual`, they are interchangeable here? Don't take it as a show-stopper, it's good to merge as it is, both do the job, I just wonder if I'm missing something in how `couch_db_plugin` works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Fix incorrect use of eunit fixtures
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/151#issuecomment-196987006
> why do you prefer ?assertMatch over ?assertEqual
@eiri: I used to generate random args and match that they are returned back. But then abandoned that as an overkill.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---