[GitHub] [mynewt-newt] utzig commented on a change in pull request #284: Fix build when not a git tree

[GitBox <gi...@apache.org>]

utzig commented on a change in pull request #284: Fix build when not a git tree
URL: https://github.com/apache/mynewt-newt/pull/284#discussion_r274077977
 
 

 ##########
 File path: newt/newt.go
 ##########
 @@ -140,7 +140,9 @@ func newtCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			fmt.Printf("Apache Newt\n")
 			fmt.Printf("   Version: %s\n", newtutil.NewtVersionStr)
-			fmt.Printf("  Git Hash: %s\n", newtutil.NewtGitHash)
+			if newtutil.NewtGitHash != "unknown" {
+				fmt.Printf("  Git Hash: %s\n", newtutil.NewtGitHash)
 
 Review comment:
   done!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services