[GitHub] [spark] pan3793 commented on a diff in pull request #40867: [SPARK-43208][HIVE] IsolatedClassLoader should close barrier class InputStream after reading

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #40867:
URL: https://github.com/apache/spark/pull/40867#discussion_r1172100221


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala:
##########
@@ -265,10 +265,10 @@ private[hive] class IsolatedClientLoader(
             if (loaded == null) doLoadClass(name, resolve) else loaded
           }
           def doLoadClass(name: String, resolve: Boolean): Class[_] = {
-            val classFileName = name.replaceAll("\\.", "/") + ".class"

Review Comment:
   it's exactly same as `classToPath(name)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org