You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@subversion.apache.org by da...@apache.org on 2017/07/06 10:04:00 UTC

svn commit: r1801009 - /subversion/trunk/tools/dist/security/mailer.py

Author: danielsh
Date: Thu Jul  6 10:04:00 2017
New Revision: 1801009

URL: http://svn.apache.org/viewvc?rev=1801009&view=rev
Log:
* tools/dist/security/mailer.py
  (Mailer.send_mail.send): Mention an apparent bug and its fix.

Modified:
    subversion/trunk/tools/dist/security/mailer.py

Modified: subversion/trunk/tools/dist/security/mailer.py
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/security/mailer.py?rev=1801009&r1=1801008&r2=1801009&view=diff
==============================================================================
--- subversion/trunk/tools/dist/security/mailer.py (original)
+++ subversion/trunk/tools/dist/security/mailer.py Thu Jul  6 10:04:00 2017
@@ -232,6 +232,9 @@ class Mailer(object):
             server.login(username, password)
 
         def send(message):
+            # XXX: The from,to arguments should be bare addresses with no "foo:"
+            #      prefix.  It works this way in practice, but that appears to
+            #      be an accident of implementation of smtplib.
             server.sendmail("From: " + message['From'],
                             "To: " + message['To'],
                             message.as_string())