You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by interma <gi...@git.apache.org> on 2017/06/15 02:41:16 UTC
[GitHub] incubator-hawq pull request #1256: HAWQ-1485. fix exception of decryptPasswo...
GitHub user interma opened a pull request:
https://github.com/apache/incubator-hawq/pull/1256
HAWQ-1485. fix exception of decryptPassword twice in lookupResource()
In my earlier PR, *decryptPassword()* is called in the beginning of *lookupResource()*, but *BaseClient* (a ranger lib) also need decrypt password in some situation, decrypt twice will cause a exception.
This PR fixed this issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/interma/interma-hawq hawq-1485
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1256
----
commit ee200369c80df50947571fb04b51684ec19f02be
Author: interma <in...@outlook.com>
Date: 2017-06-14T10:22:50Z
HAWQ-1485. fix exception of decryptPassword twice in lookupResource()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1256: HAWQ-1485. Fix exception of decryptPasswo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1256: HAWQ-1485. fix exception of decryptPassword twic...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1256
@linwen @zhangh43 @stanlyxiang help to review again, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1256: HAWQ-1485. fix exception of decryptPasswo...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1256#discussion_r122109467
--- Diff: ranger-plugin/admin-plugin/src/main/java/org/apache/hawq/ranger/service/RangerServiceHawq.java ---
@@ -112,7 +119,7 @@ private void decryptPassword(Map<String, String> configs) throws Exception {
// when decrypt failed do nothing
LOG.warn("decrypt_password failed: " + e);
}
- configs.put("password", normal_password);
+ configs.put("password_jdbc", normal_password);
--- End diff --
put the decrypted password into a new field, so it doesn't influence the BaseClient decrypt it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1256: HAWQ-1485. Fix exception of decryptPassword twic...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1256
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---