[jira] [Commented] (DRILL-5924) native-client: Support user-specified CXX_FLAGS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236700#comment-16236700 ] 

ASF GitHub Bot commented on DRILL-5924:
---------------------------------------

GitHub user xhochy opened a pull request:

    https://github.com/apache/drill/pull/1022

    DRILL-5924: native-client: Support user-specified CXX_FLAGS

    Also remove the redundant sets of `CMAKE_CXX_FLAGS`. They are set on a global scope so that there is no need to reset them more locally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xhochy/drill native/extend-cxxflags

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1022.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1022
    
----
commit 0e96d851c9993ecd6be57fe419ce959b03d4a908
Author: Korn, Uwe <uw...@blue-yonder.com>
Date:   2017-10-28T19:45:51Z

    DRILL-5924: native-client: Support user-specified CXX_FLAGS

----


> native-client: Support user-specified CXX_FLAGS
> -----------------------------------------------
>
>                 Key: DRILL-5924
>                 URL: https://issues.apache.org/jira/browse/DRILL-5924
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Client - C++
>            Reporter: Uwe L. Korn
>
> Currently the build process for the native client overrides the CXX_FLAGS supplied by the user. In some cases we need to pass additional flags, e.g. {{-fpermissive}}, to the build to have it succeed. Thus instead of overriding these flags, they should only be expanded.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)