You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2016/04/18 15:44:26 UTC

[jira] [Created] (OAK-4221) Move duplicate constants to ExternalLoginModuleTestBase

angela created OAK-4221:
---------------------------

             Summary: Move duplicate constants to ExternalLoginModuleTestBase
                 Key: OAK-4221
                 URL: https://issues.apache.org/jira/browse/OAK-4221
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: auth-external
            Reporter: angela
            Priority: Trivial


some constants are duplicated across the tests extending from {{ExternalLoginModuleTestBase}}:

- userId
- TEST_CONSTANT_PROPERTY_NAME
- TEST_CONSTANT_PROPERTY_VALUE

and equally used in the setup of the base-class.
I would therefore suggest to move them to {{ExternalLoginModuleTestBase}} in order to simplify and improve the test code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)