You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2016/06/01 10:07:59 UTC
[jira] [Commented] (HADOOP-13171) Add StorageStatistics to S3A;
instrument some more operations
[ https://issues.apache.org/jira/browse/HADOOP-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310066#comment-15310066 ]
Steve Loughran commented on HADOOP-13171:
-----------------------------------------
I'll see about a trunk patch too.
Checkstyle-wise, only one complaint is in production code
{code}
public S3AFastOutputStream(AmazonS3Client client,:10: More than 7 parameters (found 9).
{code}
that's a wontfix. Test-code side; some on line-length and imports, which I'll fix. A few on some fields for the test data structures where some of the fields aren't encapsulated. I really think that bit of style checking in test code is overkill. Production, I'm happy with it for the long-term maintenance, especially for managing derived code. But for tests? Overkill.
Even so, those contract tests are externally used, so I'll do the wrapping. I just think checkstyle is whining.
> Add StorageStatistics to S3A; instrument some more operations
> -------------------------------------------------------------
>
> Key: HADOOP-13171
> URL: https://issues.apache.org/jira/browse/HADOOP-13171
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-13171-branch-2-001.patch, HADOOP-13171-branch-2-002.patch, HADOOP-13171-branch-2-003.patch, HADOOP-13171-branch-2-004.patch, HADOOP-13171-branch-2-005.patch, HADOOP-13171-branch-2-006.patch, HADOOP-13171-branch-2-007.patch, HADOOP-13171-branch-2-008.patch, HADOOP-13171-branch-2-009.patch, HADOOP-13171-branch-2-010.patch, HADOOP-13171-branch-2-011.patch, HADOOP-13171-branch-2-012.patch
>
>
> Add {{StorageStatistics}} support to S3A, collecting the same metrics as the instrumentation, but sharing across all instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org