You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/04/26 00:00:08 UTC
[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10214
Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type
......................................................................
IMPALA-6529: [DOCS] Output type of round function matches the input type
Output types of the following functions now match the input types:
- round
- ceil
- floor
- trunc
Cherry-picks: Cherry-picks: not for 2.x
Change-Id: I5c80de2384e606bd59723e40c1c97efc32f1cbac
---
M docs/topics/impala_math_functions.xml
1 file changed, 11 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/10214/1
--
To view, visit http://gerrit.cloudera.org:8080/10214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c80de2384e606bd59723e40c1c97efc32f1cbac
Gerrit-Change-Number: 10214
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10214 )
Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/269/
--
To view, visit http://gerrit.cloudera.org:8080/10214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c80de2384e606bd59723e40c1c97efc32f1cbac
Gerrit-Change-Number: 10214
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 00:23:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10214 )
Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type
......................................................................
Patch Set 1:
Could I have quick reviews for this to make it to the 3.0 release? Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/10214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c80de2384e606bd59723e40c1c97efc32f1cbac
Gerrit-Change-Number: 10214
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 00:02:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type
Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/10214 )
Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/10214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c80de2384e606bd59723e40c1c97efc32f1cbac
Gerrit-Change-Number: 10214
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 00:22:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10214 )
Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c80de2384e606bd59723e40c1c97efc32f1cbac
Gerrit-Change-Number: 10214
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 00:40:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10214 )
Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type
......................................................................
IMPALA-6529: [DOCS] Output type of round function matches the input type
Output types of the following functions now match the input types:
- round
- ceil
- floor
- trunc
Cherry-picks: Cherry-picks: not for 2.x
Change-Id: I5c80de2384e606bd59723e40c1c97efc32f1cbac
Reviewed-on: http://gerrit.cloudera.org:8080/10214
Reviewed-by: Greg Rahn <gr...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_math_functions.xml
1 file changed, 11 insertions(+), 16 deletions(-)
Approvals:
Greg Rahn: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c80de2384e606bd59723e40c1c97efc32f1cbac
Gerrit-Change-Number: 10214
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>