[GitHub] [kafka] dajac commented on a change in pull request #10082: MINOR: use 'mapKey' to avoid unnecessary grouped data

[GitBox <gi...@apache.org>]

dajac commented on a change in pull request #10082:
URL: https://github.com/apache/kafka/pull/10082#discussion_r575343945



##########
File path: clients/src/main/resources/common/message/ElectLeadersRequest.json
##########
@@ -28,7 +28,7 @@
     { "name": "TopicPartitions", "type": "[]TopicPartitions", "versions": "0+", "nullableVersions": "0+",
       "about": "The topic partitions to elect leaders.",
       "fields": [
-        { "name": "Topic", "type": "string", "versions": "0+", "entityType": "topicName",
+        { "name": "Topic", "type": "string", "versions": "0+", "entityType": "topicName", "mapKey": true,
           "about": "The name of a topic." },
         { "name": "PartitionId", "type": "[]int32", "versions": "0+",

Review comment:
       nit: While we are here, should we rename this field to `Partitions`? I was confused by this while reading the code. When I read `PartitionId`, I don't really expect an array.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org