[jira] [Commented] (ZOOKEEPER-1998) C library calls getaddrinfo unconditionally from zookeeper_interest

["Michael K. Edwards (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695483#comment-16695483 ] 

Michael K. Edwards commented on ZOOKEEPER-1998:
-----------------------------------------------

This seems like it could be pretty serious in some environments.  Addressable for 3.5.5?

> C library calls getaddrinfo unconditionally from zookeeper_interest
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1998
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1998
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.5.0
>            Reporter: Raul Gutierrez Segales
>            Assignee: Raul Gutierrez Segales
>            Priority: Major
>             Fix For: 3.6.0
>
>
> (commented this on ZOOKEEPER-338)
> I've just noticed that we call getaddrinfo from zookeeper_interest... on every call. So from zookeeper_interest we always call update_addrs:
> https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L2082
> which in turns unconditionally calls resolve_hosts:
> https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L787
> which does the unconditional calls to getaddrinfo:
> https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L648
> We should fix this since it'll make 3.5.0 slower for people relying on DNS. I think this is happened as part of ZOOKEEPER-107 in which the list of servers can be updated. 
> cc: [~shralex], [~phunt], [~fpj]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)