[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #9688: Make cache work again for annotations

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #9688:
URL: https://github.com/apache/incubator-superset/pull/9688#discussion_r417601908



##########
File path: superset/connectors/sqla/models.py
##########
@@ -84,6 +84,7 @@ class AnnotationDatasource(BaseDatasource):
     """
 
     cache_timeout = 0
+    changed_on = None

Review comment:
       @villebro I'm hesitant to do that as changed_on is a sa.Column and is only causing problems for the classes that inherit from AuditMixinNullable and are not actual sqllachemy models if I understand it right. AnnotationDatasource is an exception case there.
   ```
       changed_on = sa.Column(
           sa.DateTime, default=datetime.now, onupdate=datetime.now, nullable=True
       )
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org