You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/10 08:38:31 UTC

[GitHub] [pinot] codecov-commenter commented on pull request #10748: [WIP] refactor query planning phase

codecov-commenter commented on PR #10748:
URL: https://github.com/apache/pinot/pull/10748#issuecomment-1541585370

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10748](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d5f3310) into [master](https://app.codecov.io/gh/apache/pinot/commit/7c3dd06a9b0966551b84512af97259c6c5c35537?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c3dd06) will **increase** coverage by `1.87%`.
   > The diff coverage is `67.38%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10748      +/-   ##
   ============================================
   + Coverage     68.53%   70.41%   +1.87%     
   - Complexity     6453     6470      +17     
   ============================================
     Files          2124     2158      +34     
     Lines        114346   115543    +1197     
     Branches      17254    17367     +113     
   ============================================
   + Hits          78372    81364    +2992     
   + Misses        30426    28535    -1891     
   - Partials       5548     5644      +96     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | integration1 | `24.07% <0.58%> (-0.36%)` | :arrow_down: |
   | integration2 | `23.67% <0.00%> (?)` | |
   | unittests1 | `67.99% <67.19%> (+0.13%)` | :arrow_up: |
   | unittests2 | `13.70% <0.00%> (-0.13%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...not/query/planner/DispatchableSubPlanMetadata.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9EaXNwYXRjaGFibGVTdWJQbGFuTWV0YWRhdGEuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../pinot/query/planner/logical/LiteralValueNode.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9sb2dpY2FsL0xpdGVyYWxWYWx1ZU5vZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ot/query/planner/logical/PinotQueryFragmenter.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9sb2dpY2FsL1Bpbm90UXVlcnlGcmFnbWVudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...not/query/planner/logical/PlanFragmentVisitor.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9sb2dpY2FsL1BsYW5GcmFnbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/pinot/query/planner/logical/SubPlanVisitor.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9sb2dpY2FsL1N1YlBsYW5WaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...hysical/colocated/GreedyShuffleRewriteVisitor.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9waHlzaWNhbC9jb2xvY2F0ZWQvR3JlZWR5U2h1ZmZsZVJld3JpdGVWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../org/apache/pinot/query/routing/StageMetadata.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcm91dGluZy9TdGFnZU1ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...pinot/query/planner/logical/SubPlanFragmenter.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9sb2dpY2FsL1N1YlBsYW5GcmFnbWVudGVyLmphdmE=) | `62.50% <47.82%> (ø)` | |
   | [...che/pinot/query/planner/plannode/ExchangeNode.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9wbGFubm9kZS9FeGNoYW5nZU5vZGUuamF2YQ==) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
   | [.../pinot/query/planner/DispatchablePlanFragment.java](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcXVlcnktcGxhbm5lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcGxhbm5lci9EaXNwYXRjaGFibGVQbGFuRnJhZ21lbnQuamF2YQ==) | `81.25% <81.25%> (ø)` | |
   | ... and [18 more](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ... and [217 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10748/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org