You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/24 12:29:16 UTC
[GitHub] [inlong] GanfengTan opened a new pull request, #5677: [INLONG-5675][Agent] Support custom fixed ip for Agent
GanfengTan opened a new pull request, #5677:
URL: https://github.com/apache/inlong/pull/5677
Support custom fixed ip for Agent.
For example:
Ip has to fixed in the k8s.
- Fixes #5675
### Motivation
Add config information.
### Modifications
No message.
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5677: [INLONG-5675][Agent] Support custom fixed ip for Agent
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5677:
URL: https://github.com/apache/inlong/pull/5677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5677: [INLONG-5675][Agent] Support custom fixed ip for Agent
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5677:
URL: https://github.com/apache/inlong/pull/5677#discussion_r953790079
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/utils/AgentUtils.java:
##########
@@ -348,6 +349,10 @@ public static String getmValue(String addictiveAttr) {
* Check agent ip from manager
*/
public static String fetchLocalIp() {
+ if (AgentConfiguration.getAgentConf().hasKey(CUSTOM_FIXED_IP) && StringUtils
Review Comment:
Suggested changing to:
```
if (AgentConfiguration.getAgentConf().hasKey(CUSTOM_FIXED_IP)
&& StringUtils.isNoneBlank(AgentConfiguration.getAgentConf().get(CUSTOM_FIXED_IP))) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #5677: [INLONG-5675][Agent] Support custom fixed ip for Agent
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on code in PR #5677:
URL: https://github.com/apache/inlong/pull/5677#discussion_r953905668
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/utils/AgentUtils.java:
##########
@@ -348,6 +349,10 @@ public static String getmValue(String addictiveAttr) {
* Check agent ip from manager
*/
public static String fetchLocalIp() {
+ if (AgentConfiguration.getAgentConf().hasKey(CUSTOM_FIXED_IP) && StringUtils
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org