You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/23 08:28:17 UTC
[GitHub] [hudi] dongkelun opened a new pull request, #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
dongkelun opened a new pull request, #5406:
URL: https://github.com/apache/hudi/pull/5406
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
I think only when ASYNC_CLEAN is true,We need keep the last commit before the earliest commit to retain
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113896848
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1107451624
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed272b51dfc224ce0adc2123cd754d7f815856c2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1107856116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed272b51dfc224ce0adc2123cd754d7f815856c2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258)
* 6628c0dbdca55f917d46c65881cd33a0f5415710 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1107435340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed272b51dfc224ce0adc2123cd754d7f815856c2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1108747552
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6628c0dbdca55f917d46c65881cd33a0f5415710 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270)
* 11ec83bd7edba94db333767b05d83fe7c8365c34 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1108812806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11ec83bd7edba94db333767b05d83fe7c8365c34 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292)
* b8a84374628e95b881205e6dc80db3de03599898 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112001717
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ecba2b1b988f7cdcfdae38e84521c010f8a329e9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322)
* 76f756f37a190fe4e434c23491d73b2c134aad71 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1109597520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8a84374628e95b881205e6dc80db3de03599898 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294)
* ecba2b1b988f7cdcfdae38e84521c010f8a329e9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1108751560
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6628c0dbdca55f917d46c65881cd33a0f5415710 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270)
* 11ec83bd7edba94db333767b05d83fe7c8365c34 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1120365156
@pratyakshsharma I think it's enough to reserve 300 minutes for query. There's no need to reserve one more 30 minutes. If we want to reserve more, we can increase the configuration parameters. In addition, other cleaning policies do not retain one more version. I don't understand why they are not consistent.And I think it's a little redundant to retain one more version, because we have reserved enough time through configuration parameters. And it is not consistent with the configuration parameters, which is easy to confuse users.
So I think it's reasonable not to keep one more version, and the code is more concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1246103721
> I do not want to touch something that existed for 3+ years w/o understanding the repurcussions. will probably wait to hear from vinoth or prasanna/balaji. we can leave the patch open until then.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112373019
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112467801
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 44bcae973cc953d48d1cee358c19cf7857504a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1108767306
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11ec83bd7edba94db333767b05d83fe7c8365c34 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292)
* b8a84374628e95b881205e6dc80db3de03599898 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1108763008
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6628c0dbdca55f917d46c65881cd33a0f5415710 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270)
* 11ec83bd7edba94db333767b05d83fe7c8365c34 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292)
* b8a84374628e95b881205e6dc80db3de03599898 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1120362938
Yes when 0011 commit is completed, 300 minutes have elapsed. But the original idea from the beginning has been to allow some more buffer time to allow the query to finish properly. As a user, you do not want to kill a query which has been running for such a long time and might just be finishing up at the time cleaner triggers and deletes the concerned file. Query can be delayed by some time due to retries or any such real world distributed systems problems. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1107434965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed272b51dfc224ce0adc2123cd754d7f815856c2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1110750154
I'm wrong. Whether async clean or not, we shouldn't keep he last commit before the earliest commit to retain. And when `hoodie.auto.commit` is false, we also keep an additional version that should not be kept. I will change the code again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112074582
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76f756f37a190fe4e434c23491d73b2c134aad71 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361)
* 44bcae973cc953d48d1cee358c19cf7857504a3b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113927112
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382",
"triggerID" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"triggerType" : "PUSH"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401",
"triggerID" : "1113896848",
"triggerType" : "MANUAL"
}, {
"hash" : "1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bf4a7b2aebc313e7e4130622ca1e66a335bb568 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401)
* 1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1120376579
> Okay, you have a valid point here. I agree this policy has been a bit confusing from the very beginning because of this extra logic of retaining one more commit. My only concern was this might break things for existing users who have been using this cleaning policy and assume one extra commit will be retained. I will go over the changes by tomorrow.
>
> I think it will be good to get opinions from @nsivabalan @bvaradar as well on this change. If they support, we are good to go.
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1240120146
hey @danny0405 : may be there is some rational behind the original intent. Its just deducting 1 commit from what user wants right. as of now, I don't feel this is giving us much or fixing any regression. can we drop the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112036673
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76f756f37a190fe4e434c23491d73b2c134aad71 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361)
* 44bcae973cc953d48d1cee358c19cf7857504a3b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112174073
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44bcae973cc953d48d1cee358c19cf7857504a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1120223144
@dongkelun I guess there is some confusion with respect to the documentation for the said config. I have added a review comment https://github.com/apache/hudi/pull/4927#discussion_r867342264 to correct this.
Also regarding the existing functionality, the code is fine in its correct form and no changes are required. To quote the documentation from java docs - `We assume that the max(query execution time) == commit_batch_time * config.getCleanerCommitsRetained().
* This is 5 hours by default (assuming ingestion is running every 30 minutes). This is essential to leave the file
* used by the query that is running for the max time.`
Please let me know if you still have any doubts and I can explain it further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113918865
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382",
"triggerID" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"triggerType" : "PUSH"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401",
"triggerID" : "1113896848",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1bf4a7b2aebc313e7e4130622ca1e66a335bb568 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vgkowski commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by "vgkowski (via GitHub)" <gi...@apache.org>.
vgkowski commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1434287762
this behavior is not expected in GDPR context when you want to hard delete records and clean old files. You generally run a delete operation with `KEEP_LATEST_COMMITS` to 1 and you don't want old records supposedly deleted to appear in any time travel query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1120375006
Okay, you have a valid point here. I agree this policy has been a bit confusing from the very beginning because of this extra logic of retaining one more commit. My only concern was this might break things for existing users who have been using this cleaning policy and assume one extra commit will be retained. I will go over the changes by tomorrow.
I think it will be good to get opinions from @nsivabalan @bvaradar as well on this change. If they support, we are good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112384436
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 44bcae973cc953d48d1cee358c19cf7857504a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112812272
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 44bcae973cc953d48d1cee358c19cf7857504a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1107886246
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6628c0dbdca55f917d46c65881cd33a0f5415710 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1109699237
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ecba2b1b988f7cdcfdae38e84521c010f8a329e9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112033904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ecba2b1b988f7cdcfdae38e84521c010f8a329e9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322)
* 76f756f37a190fe4e434c23491d73b2c134aad71 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361)
* 44bcae973cc953d48d1cee358c19cf7857504a3b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1245443080
I do not want to touch something that existed for 3+ years w/o understanding the repurcussions. will probably wait to hear from vinoth or prasanna/balaji. we can leave the patch open until then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113004464
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382",
"triggerID" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44bcae973cc953d48d1cee358c19cf7857504a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378)
* 1bf4a7b2aebc313e7e4130622ca1e66a335bb568 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112799961
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1108918215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8a84374628e95b881205e6dc80db3de03599898 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1109593876
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8a84374628e95b881205e6dc80db3de03599898 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294)
* ecba2b1b988f7cdcfdae38e84521c010f8a329e9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1121285353
@vinothchandar @bvaradar : do you folks have any context around why we retain 1 extra commit compared to the configured number for num commits to retain with cleaning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113900336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382",
"triggerID" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"triggerType" : "PUSH"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401",
"triggerID" : "1113896848",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1bf4a7b2aebc313e7e4130622ca1e66a335bb568 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113927475
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382",
"triggerID" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"triggerType" : "PUSH"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401",
"triggerID" : "1113896848",
"triggerType" : "MANUAL"
}, {
"hash" : "1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8404",
"triggerID" : "1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bf4a7b2aebc313e7e4130622ca1e66a335bb568 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401)
* 1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8404)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112862396
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 44bcae973cc953d48d1cee358c19cf7857504a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113106712
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382",
"triggerID" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bf4a7b2aebc313e7e4130622ca1e66a335bb568 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113000776
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44bcae973cc953d48d1cee358c19cf7857504a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378)
* 1bf4a7b2aebc313e7e4130622ca1e66a335bb568 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1113945602
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8363",
"triggerID" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"triggerType" : "PUSH"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8371",
"triggerID" : "1112373019",
"triggerType" : "MANUAL"
}, {
"hash" : "44bcae973cc953d48d1cee358c19cf7857504a3b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8378",
"triggerID" : "1112799961",
"triggerType" : "MANUAL"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8382",
"triggerID" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"triggerType" : "PUSH"
}, {
"hash" : "1bf4a7b2aebc313e7e4130622ca1e66a335bb568",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8401",
"triggerID" : "1113896848",
"triggerType" : "MANUAL"
}, {
"hash" : "1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8404",
"triggerID" : "1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d213ea8449e1fdc88267e29c7d8a5b667b8fdf2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8404)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1120339108
> @dongkelun I guess there is some confusion with respect to the documentation for the said config. I have added a review comment [#4927 (comment)](https://github.com/apache/hudi/pull/4927#discussion_r867342264) to correct this. Also regarding the existing functionality, the code is fine in its correct form and no changes are required. To quote the documentation from java docs - `We assume that the max(query execution time) == commit_batch_time * config.getCleanerCommitsRetained().
>
> * This is 5 hours by default (assuming ingestion is running every 30 minutes). This is essential to leave the file
> * used by the query that is running for the max time.`
>
> Please let me know if you still have any doubts and I can explain it further.
| commit | retainTime(min)|
|-----|-----|
| 001.commit | 0|
| 002.commit | 30|
| 003.commit | 60|
| 004.commit | 90|
| 005.commit | 120|
| 006.commit | 150|
| 007.commit | 180|
| 008.commit | 210|
| 009.commit | 240|
| 0010.commit | 270|
| 0011.commit | 300|
As you said, a file is retained for 5 hours by default, that is, 300 minutes. So when `0011`.commit is completed,` 001.commit` has been reserved for 300 minutes, so we should not keep `001.commit` when we clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] When ASYNC_CLEAN is false,don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1107856707
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed272b51dfc224ce0adc2123cd754d7f815856c2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258)
* 6628c0dbdca55f917d46c65881cd33a0f5415710 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1240374420
> hey @dongkelun : may be there is some rational behind the original intent. Its just deducting 1 commit from what user wants right. as of now, I don't feel this is giving us much or fixing any regression. can we drop the patch.
However, I think it doesn't make much sense, and the logic becomes complicated and makes users feel confused, and removing this logic seems to have no bad effect. So I personally don't think it's necessary to keep it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5406:
URL: https://github.com/apache/hudi/pull/5406#issuecomment-1112005045
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8258",
"triggerID" : "ed272b51dfc224ce0adc2123cd754d7f815856c2",
"triggerType" : "PUSH"
}, {
"hash" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8270",
"triggerID" : "6628c0dbdca55f917d46c65881cd33a0f5415710",
"triggerType" : "PUSH"
}, {
"hash" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8292",
"triggerID" : "11ec83bd7edba94db333767b05d83fe7c8365c34",
"triggerType" : "PUSH"
}, {
"hash" : "b8a84374628e95b881205e6dc80db3de03599898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8294",
"triggerID" : "b8a84374628e95b881205e6dc80db3de03599898",
"triggerType" : "PUSH"
}, {
"hash" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322",
"triggerID" : "ecba2b1b988f7cdcfdae38e84521c010f8a329e9",
"triggerType" : "PUSH"
}, {
"hash" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361",
"triggerID" : "76f756f37a190fe4e434c23491d73b2c134aad71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ecba2b1b988f7cdcfdae38e84521c010f8a329e9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8322)
* 76f756f37a190fe4e434c23491d73b2c134aad71 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8361)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org