You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2015/03/05 04:21:14 UTC
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75282
-----------------------------------------------------------
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java
<https://reviews.apache.org/r/31575/#comment122264>
if user has write permission, but he still need read permission to read data?
- Colin Ma
On March 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 5, 2015, 3:21 a.m., Colin Ma wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java, line 28
> > <https://reviews.apache.org/r/31575/diff/1/?file=881538#file881538line28>
> >
> > if user has write permission, but he still need read permission to read data?
Currently, yes. The user need the read permission to read data
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75282
-----------------------------------------------------------
On 三月 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 5, 2015, 3:21 a.m., Colin Ma wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java, line 28
> > <https://reviews.apache.org/r/31575/diff/1/?file=881538#file881538line28>
> >
> > if user has write permission, but he still need read permission to read data?
Currently, yes. The user need the read permission to read data
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75282
-----------------------------------------------------------
On 三月 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>