[GitHub] [iceberg] SinghAsDev commented on a diff in pull request #5036: Fix concurrent transactions overwriting commits by adding hive lock heartbeats.

[GitBox <gi...@apache.org>]

SinghAsDev commented on code in PR #5036:
URL: https://github.com/apache/iceberg/pull/5036#discussion_r898245241


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -229,7 +241,8 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
     tableLevelMutex.lock();
     try {
       lockId = Optional.of(acquireLock());
-      // TODO add lock heart beating for cases where default lock timeout is too low.
+      hiveLockHeartbeat = new HiveLockHeartbeat(metaClients, lockId.get(), lockCheckMaxWaitTime);

Review Comment:
   Yea, but Iceberg does not have this config, so we can't use that. The reason I used `iceberg.hive.lock-check-max-wait-ms` is that we already advise users to keep this lower than `hive.txn.timeout`. I would be open to making this even smaller to something like `lockCheckMaxWaitTime / 2` to allow room for delays in heartbeats and/ or retries. Thoughts @pvary ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org