You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 06:27:02 UTC

[GitHub] [arrow-datafusion] msathis opened a new pull request #79: Deduplicate README.md

msathis opened a new pull request #79:
URL: https://github.com/apache/arrow-datafusion/pull/79


   # Which issue does this PR close?
   
   Closes #71 .
   
    # Rationale for this change
   
   Removing duplicated content
   
   # What changes are included in this PR?
   
   Remove duplicated content & move Developers.md to root
   
   # Are there any user-facing changes?
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on pull request #79: Deduplicate README.md

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #79:
URL: https://github.com/apache/arrow-datafusion/pull/79#issuecomment-826546649


   Thanks @msathis ! just an idea, maybe we can point the datafusion crate to the readme in the root too?
   
   https://doc.rust-lang.org/cargo/reference/manifest.html#the-readme-field


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] msathis commented on pull request #79: Deduplicate README.md

Posted by GitBox <gi...@apache.org>.
msathis commented on pull request #79:
URL: https://github.com/apache/arrow-datafusion/pull/79#issuecomment-826547787


   > Thanks @msathis ! just an idea, maybe we can point the datafusion crate to the readme in the root too?
   
   Nice idea 💡  @Dandandan. Never knew this. Will do it 👌


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] msathis commented on pull request #79: Deduplicate README.md

Posted by GitBox <gi...@apache.org>.
msathis commented on pull request #79:
URL: https://github.com/apache/arrow-datafusion/pull/79#issuecomment-826547787


   > Thanks @msathis ! just an idea, maybe we can point the datafusion crate to the readme in the root too?
   
   Nice idea 💡  @Dandandan. Never knew this. Will do it 👌


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #79: Deduplicate README.md

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #79:
URL: https://github.com/apache/arrow-datafusion/pull/79


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #79: Deduplicate README.md

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #79:
URL: https://github.com/apache/arrow-datafusion/pull/79#discussion_r620667245



##########
File path: README.md
##########
@@ -141,11 +141,11 @@ DataFusion also includes a simple command-line interactive SQL utility. See the
 - [x] SQL Parser
 - [x] SQL Query Planner
 - [x] Query Optimizer
- - [x] Constant folding
- - [x] Join Reordering
- - [x] Limit Pushdown
- - [x] Projection push down
- - [x] Predicate push down
+- [x] Constant folding
+- [x] Join Reordering
+- [x] Limit Pushdown
+- [x] Projection push down
+- [x] Predicate push down

Review comment:
       I think these were meant to be sub bullets (they are features of the query optimizer) but we can fix that in a subsequent PR)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on pull request #79: Deduplicate README.md

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #79:
URL: https://github.com/apache/arrow-datafusion/pull/79#issuecomment-826546649


   Thanks @msathis ! just an idea, maybe we can point the datafusion crate to the readme in the root too?
   
   https://doc.rust-lang.org/cargo/reference/manifest.html#the-readme-field


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org