[jira] [Closed] (KAFKA-456) ProducerSendThread calls ListBuffer.size a whole bunch. That is a O(n) operation

["Neha Narkhede (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neha Narkhede closed KAFKA-456.
-------------------------------


> ProducerSendThread calls ListBuffer.size a whole bunch. That is a O(n) operation
> --------------------------------------------------------------------------------
>
>                 Key: KAFKA-456
>                 URL: https://issues.apache.org/jira/browse/KAFKA-456
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.0
>         Environment: NA
>            Reporter: Matthew Rathbone
>            Assignee: David Arthur
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.8.0
>
>         Attachments: KAFKA-456.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Hi all,
> So there are various statements throughout the async code that call 'events.size', mostly for debugging purposes.
> Problem is that this call is O(n), so it could add up if the batch size is high. (it's a ListBuffer)
> I see this in at least ProducerSendThread (x4), likely more. Will factor this out myself soon when I start hacking on the project, just wanted to put this somewhere.



--
This message was sent by Atlassian JIRA
(v6.2#6252)