You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fang Wang <fa...@citrix.com> on 2013/05/10 22:08:07 UTC
Review Request: Protect VNC port with password on KVM.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11058/
-----------------------------------------------------------
Review request for cloudstack and Kelven Yang.
Description
-------
Add the protection for VNC port with password on KVM.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
Diff: https://reviews.apache.org/r/11058/diff/
Testing
-------
Thanks,
Fang Wang
Re: Review Request: Protect VNC port with password on KVM.
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11058/#review21882
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On May 13, 2013, 10:32 p.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11058/
> -----------------------------------------------------------
>
> (Updated May 13, 2013, 10:32 p.m.)
>
>
> Review request for cloudstack, edison su and Kelven Yang.
>
>
> Description
> -------
>
> Add the protection for VNC port with password on KVM.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
>
> Diff: https://reviews.apache.org/r/11058/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fang Wang
>
>
Re: Review Request: Protect VNC port with password on KVM.
Posted by Fang Wang <fa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11058/
-----------------------------------------------------------
(Updated May 13, 2013, 10:32 p.m.)
Review request for cloudstack, edison su and Kelven Yang.
Description
-------
Add the protection for VNC port with password on KVM.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
Diff: https://reviews.apache.org/r/11058/diff/
Testing
-------
Thanks,
Fang Wang
Re: Review Request: Protect VNC port with password on KVM.
Posted by Fang Wang <fa...@citrix.com>.
> On May 10, 2013, 8:59 p.m., David Nalley wrote:
> > Is there a jira bug for this?
> >
> > What kind of testing can we add to this to confirm it actually works as intended?
there is not a bug for this, it is part of some security enhancements.
- Fang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11058/#review20430
-----------------------------------------------------------
On May 10, 2013, 8:08 p.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11058/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 8:08 p.m.)
>
>
> Review request for cloudstack and Kelven Yang.
>
>
> Description
> -------
>
> Add the protection for VNC port with password on KVM.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
>
> Diff: https://reviews.apache.org/r/11058/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fang Wang
>
>
Re: Review Request: Protect VNC port with password on KVM.
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11058/#review20430
-----------------------------------------------------------
Is there a jira bug for this?
What kind of testing can we add to this to confirm it actually works as intended?
- David Nalley
On May 10, 2013, 8:08 p.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11058/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 8:08 p.m.)
>
>
> Review request for cloudstack and Kelven Yang.
>
>
> Description
> -------
>
> Add the protection for VNC port with password on KVM.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
>
> Diff: https://reviews.apache.org/r/11058/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fang Wang
>
>