You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/30 01:33:33 UTC
Re: Review Request 25207: Fixed a bug in the allocator that causes
filter to be unnecessarily installed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25207/
-----------------------------------------------------------
(Updated Aug. 29, 2014, 11:33 p.m.)
Review request for mesos, Dominic Hamon and Vinod Kone.
Summary (updated)
-----------------
Fixed a bug in the allocator that causes filter to be unnecessarily installed.
Bugs: MESOS-1749
https://issues.apache.org/jira/browse/MESOS-1749
Repository: mesos-git
Description
-------
The bug was introduced when we did the merge of resourcesUnused and resourcesRecovered (https://reviews.apache.org/r/24331/)
It causes bugs like MESOS-1749.
So should not create a filter if 'filters' is None(). But right now, we always install a filter no matter what!
Diffs
-----
src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
Diff: https://reviews.apache.org/r/25207/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 25207: Fixed a bug in the allocator that causes
filter to be unnecessarily installed.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25207/#review51933
-----------------------------------------------------------
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/25207/#comment90630>
rephrase the comment.
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/25207/#comment90631>
revert to previous semantics here.
- Vinod Kone
On Aug. 29, 2014, 11:33 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25207/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 11:33 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1749
> https://issues.apache.org/jira/browse/MESOS-1749
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug was introduced when we did the merge of resourcesUnused and resourcesRecovered (https://reviews.apache.org/r/24331/)
>
> It causes bugs like MESOS-1749.
>
> So should not create a filter if 'filters' is None(). But right now, we always install a filter no matter what!
>
>
> Diffs
> -----
>
> src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
>
> Diff: https://reviews.apache.org/r/25207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25207: Fixed a bug in the allocator that causes
filter to be unnecessarily installed.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25207/#review51925
-----------------------------------------------------------
Ship it!
Ship It!
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/25207/#comment90623>
nit: you could move the if up a line and make this else if
- Dominic Hamon
On Aug. 29, 2014, 4:33 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25207/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 4:33 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1749
> https://issues.apache.org/jira/browse/MESOS-1749
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug was introduced when we did the merge of resourcesUnused and resourcesRecovered (https://reviews.apache.org/r/24331/)
>
> It causes bugs like MESOS-1749.
>
> So should not create a filter if 'filters' is None(). But right now, we always install a filter no matter what!
>
>
> Diffs
> -----
>
> src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
>
> Diff: https://reviews.apache.org/r/25207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25207: Fixed a bug in the allocator that causes
filter to be unnecessarily installed.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25207/#review52057
-----------------------------------------------------------
Patch looks great!
Reviews applied: [25207]
All tests passed.
- Mesos ReviewBot
On Sept. 2, 2014, 5:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25207/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 5:04 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1749
> https://issues.apache.org/jira/browse/MESOS-1749
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug was introduced when we did the merge of resourcesUnused and resourcesRecovered (https://reviews.apache.org/r/24331/)
>
> It causes bugs like MESOS-1749.
>
> So should not create a filter if 'filters' is None(). But right now, we always install a filter no matter what!
>
>
> Diffs
> -----
>
> src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
>
> Diff: https://reviews.apache.org/r/25207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25207: Fixed a bug in the allocator that causes
filter to be unnecessarily installed.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25207/#review52046
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 2, 2014, 5:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25207/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 5:04 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1749
> https://issues.apache.org/jira/browse/MESOS-1749
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug was introduced when we did the merge of resourcesUnused and resourcesRecovered (https://reviews.apache.org/r/24331/)
>
> It causes bugs like MESOS-1749.
>
> So should not create a filter if 'filters' is None(). But right now, we always install a filter no matter what!
>
>
> Diffs
> -----
>
> src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
>
> Diff: https://reviews.apache.org/r/25207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25207: Fixed a bug in the allocator that causes
filter to be unnecessarily installed.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25207/
-----------------------------------------------------------
(Updated Sept. 2, 2014, 5:04 p.m.)
Review request for mesos, Dominic Hamon and Vinod Kone.
Changes
-------
Vinod's comment.
Bugs: MESOS-1749
https://issues.apache.org/jira/browse/MESOS-1749
Repository: mesos-git
Description
-------
The bug was introduced when we did the merge of resourcesUnused and resourcesRecovered (https://reviews.apache.org/r/24331/)
It causes bugs like MESOS-1749.
So should not create a filter if 'filters' is None(). But right now, we always install a filter no matter what!
Diffs (updated)
-----
src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
Diff: https://reviews.apache.org/r/25207/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 25207: Fixed a bug in the allocator that causes
filter to be unnecessarily installed.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25207/#review51958
-----------------------------------------------------------
Patch looks great!
Reviews applied: [25207]
All tests passed.
- Mesos ReviewBot
On Aug. 29, 2014, 11:33 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25207/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 11:33 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1749
> https://issues.apache.org/jira/browse/MESOS-1749
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug was introduced when we did the merge of resourcesUnused and resourcesRecovered (https://reviews.apache.org/r/24331/)
>
> It causes bugs like MESOS-1749.
>
> So should not create a filter if 'filters' is None(). But right now, we always install a filter no matter what!
>
>
> Diffs
> -----
>
> src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
>
> Diff: https://reviews.apache.org/r/25207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>