[Impala-ASF-CR] IMPALA-12818: Intermediate Result Caching plan node framework

["Kurt Deschler (Code Review)" <ge...@cloudera.org>]

Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21035 )

Change subject: IMPALA-12818: Intermediate Result Caching plan node framework
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/21035/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21035/3//COMMIT_MSG@24
PS3, Line 24: eligible location. Eligibility is currently restricted to immediately
It's a little awkward that placement is restricted in this commit since that likely makes untested codepaths.


http://gerrit.cloudera.org:8080/#/c/21035/3/be/src/exec/tuple-cache-node.cc
File be/src/exec/tuple-cache-node.cc:

http://gerrit.cloudera.org:8080/#/c/21035/3/be/src/exec/tuple-cache-node.cc@69
PS3, Line 69:   // Note: TupleCacheNode does not support limits, so this does not need logic to
Limits can be supported for deterministic results. Maybe change to a TODO.


http://gerrit.cloudera.org:8080/#/c/21035/3/fe/src/main/java/org/apache/impala/planner/PlanNode.java
File fe/src/main/java/org/apache/impala/planner/PlanNode.java:

http://gerrit.cloudera.org:8080/#/c/21035/3/fe/src/main/java/org/apache/impala/planner/PlanNode.java@499
PS3, Line 499:   private void initThrift(TPlanNode msg, TupleCacheInfo tupleCacheInfo) {
Maybe cleaner to split this function so the subset can be called for IRC.


http://gerrit.cloudera.org:8080/#/c/21035/3/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java
File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java:

http://gerrit.cloudera.org:8080/#/c/21035/3/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@150
PS3, Line 150:     assertEquals(intersection.size(), 0);
Consider verifying the hash trace here also.


http://gerrit.cloudera.org:8080/#/c/21035/3/testdata/workloads/functional-query/queries/QueryTest/explain-level1.test
File testdata/workloads/functional-query/queries/QueryTest/explain-level1.test:

http://gerrit.cloudera.org:8080/#/c/21035/3/testdata/workloads/functional-query/queries/QueryTest/explain-level1.test@63
PS3, Line 63: row_regex:.*\[TPlanNode\(.*\]
Maybe better to verify the actual cache key and at least the first and last trace lines so we can easily now if something fundamental changes.



-- 
To view, visit http://gerrit.cloudera.org:8080/21035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1f36a87dcce6efd5d1e1f0bc04009bf009b1961
Gerrit-Change-Number: 21035
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 16:55:45 +0000
Gerrit-HasComments: Yes