You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/01/28 19:28:14 UTC
[GitHub] incubator-guacamole-client pull request #116: GUACAMOLE-47: Store remote add...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/116
GUACAMOLE-47: Store remote address/hostname within credentials.
While documenting the changes for [GUACAMOLE-47](https://issues.apache.org/jira/browse/GUACAMOLE-47), I noticed that we are pulling the hostname and address directly from the `HttpServletRequest` each time token substitution takes place. This is bad because servlet containers will often reuse the `HttpServletRequest` object. When pulled from a `Credentials` object, its contents cannot be relied upon outside the scope of the authentication request which produced those `Credentials`.
If these values are to be accessible when users connect via Guacamole, they will need to be stored within `Credentials` just like the username and password.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client address-credentials
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 1ed73e6a9778c321aefc4587c5bd96cb658a0291
Author: Michael Jumper <mj...@apache.org>
Date: 2017-01-28T19:20:23Z
GUACAMOLE-47: Correct documentation of address/hostname token names.
commit b336e26cb2e4cda2f309f5cf0c26875099dcdaa7
Author: Michael Jumper <mj...@apache.org>
Date: 2017-01-28T19:23:31Z
GUACAMOLE-47: Store remote address and hostname within Credentials.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #116: GUACAMOLE-47: Store remote add...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---