[GitHub] [accumulo] dlmarion commented on a diff in pull request #3219: Use AtomicInteger for index pointers in SeekableByteArrayInputStream

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on code in PR #3219:
URL: https://github.com/apache/accumulo/pull/3219#discussion_r1123060729


##########
core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/SeekableByteArrayInputStream.java:
##########
@@ -42,13 +43,13 @@ public class SeekableByteArrayInputStream extends InputStream {
   @SuppressFBWarnings(value = "VO_VOLATILE_REFERENCE_TO_ARRAY",
       justification = "see explanation above")
   private volatile byte[] buffer;
-  private int cur;
-  private int max;
+  private final AtomicInteger cur;
+  private final AtomicInteger max;

Review Comment:
   Looking back at this, I think that `max` can just be modified to be `final` instead of making it an `AtomicInteger`. It's set in the constructor and never changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org