You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Kikyou1997 (via GitHub)" <gi...@apache.org> on 2023/06/02 11:11:49 UTC
[GitHub] [doris] Kikyou1997 opened a new pull request, #20383: [fix](stats) Fix forbid unknown stats
Kikyou1997 opened a new pull request, #20383:
URL: https://github.com/apache/doris/pull/20383
## Proposed changes
The statistics derivation for queries on databases A and B, as well as expressions involving hidden columns, should not throw an exception when the statistics are unknown, even if the forbid_unknown_col_stats parameter is set to true.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #20383: [fix](stats) Fix forbid unknown stats
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #20383:
URL: https://github.com/apache/doris/pull/20383#issuecomment-1575991004
dup with #20362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #20383: [fix](stats) Fix forbid unknown stats
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #20383:
URL: https://github.com/apache/doris/pull/20383#discussion_r1217397824
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:
##########
@@ -551,12 +555,21 @@ private Statistics computeScan(Scan scan) {
throw new RuntimeException(String.format("Invalid slot: %s", slotReference.getExprId()));
}
ColumnStatistic cache = Config.enable_stats ? getColumnStatistic(table, colName) : ColumnStatistic.UNKNOWN;
- if (cache == ColumnStatistic.UNKNOWN && !colName.equals("__DORIS_DELETE_SIGN__")) {
+ if (cache == ColumnStatistic.UNKNOWN && !ignoreUnknownError(table, colName)) {
Review Comment:
!ignoreUnknownError(table, colName)
this condition should be moved to line 559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow closed pull request #20383: [fix](stats) Fix forbid unknown stats
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow closed pull request #20383: [fix](stats) Fix forbid unknown stats
URL: https://github.com/apache/doris/pull/20383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #20383: [fix](stats) Fix forbid unknown stats
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #20383:
URL: https://github.com/apache/doris/pull/20383#issuecomment-1573562138
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org