[GitHub] [airflow] samgans edited a comment on pull request #16916: Deprecate Tableau personal token authentication

[GitBox <gi...@apache.org>]

samgans edited a comment on pull request #16916:
URL: https://github.com/apache/airflow/pull/16916#issuecomment-879826509


   Hello, @potiuk . The thing is that static check asks me to change this:
   ```
   warnings.warn(
               "Authentication via personal access token is deprecated. "
               "Please, use the password authentication to avoid inconsistencies.",
               DeprecationWarning
           )
   ```
   
   To this:
   
   ```
   warnings.warn(
               "Authentication via personal access token is deprecated. "
               "Please, use the password authentication to avoid inconsistencies.",
               DeprecationWarning,
           )
   ```
   
   Which is not the thing we should have, I guess. What do you think?
   
   **UPD**: I've rechecked the PEP8 and see that the trailing comma, in this case, is not redundant if we expect this to be extended. I think I will put it here. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org