You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/12/28 16:10:02 UTC
[PR] Fix compatibility with FastAPI>0.128.0 [airflow]
potiuk opened a new pull request, #59872:
URL: https://github.com/apache/airflow/pull/59872
Ad Cadwyn 6.0.0rc1 is released with compatibility with FastAPI 0.128.0+, we can now attempt to run the tests with it and see what else needs to be fixed.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #59872:
URL: https://github.com/apache/airflow/pull/59872#discussion_r2649858296
##########
airflow-core/pyproject.toml:
##########
@@ -77,20 +77,15 @@ dependencies = [
"argcomplete>=1.10",
"asgiref>=2.3.0",
"attrs>=22.1.0, !=25.2.0",
- "cadwyn>=5.6.2",
+ "cadwyn>=6.0.0rc1",
Review Comment:
Wow, that is FAST! During vacation time, on a Sunday... impressive speed and OpenSource engagement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #59872:
URL: https://github.com/apache/airflow/pull/59872#discussion_r2649826306
##########
airflow-core/pyproject.toml:
##########
@@ -77,20 +77,15 @@ dependencies = [
"argcomplete>=1.10",
"asgiref>=2.3.0",
"attrs>=22.1.0, !=25.2.0",
- "cadwyn>=5.6.2",
+ "cadwyn>=6.0.0rc1",
Review Comment:
Hopefully will not take too long this PR is a proof that it fixes the problem and works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59872:
URL: https://github.com/apache/airflow/pull/59872#issuecomment-3694869657
> As far as I see the generation is just a "mock" that we set, can we just remove this if the compatibility as mock is not needed anymore?
Likely - I will have to see why it was mocked -> maybe there was a reason ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59872:
URL: https://github.com/apache/airflow/pull/59872#issuecomment-3694900219
Looks good - but I would prefer to merge it when 6.0.0 is released (asked Stanislav when he plans to release it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59872:
URL: https://github.com/apache/airflow/pull/59872#discussion_r2649834131
##########
airflow-core/pyproject.toml:
##########
@@ -77,20 +77,15 @@ dependencies = [
"argcomplete>=1.10",
"asgiref>=2.3.0",
"attrs>=22.1.0, !=25.2.0",
- "cadwyn>=5.6.2",
+ "cadwyn>=6.0.0rc1",
Review Comment:
Will be released today :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59872:
URL: https://github.com/apache/airflow/pull/59872#discussion_r2649888124
##########
airflow-core/pyproject.toml:
##########
@@ -77,20 +77,15 @@ dependencies = [
"argcomplete>=1.10",
"asgiref>=2.3.0",
"attrs>=22.1.0, !=25.2.0",
- "cadwyn>=5.6.2",
+ "cadwyn>=6.0.0rc1",
Review Comment:
Indeed. I double-thanked him for this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59872:
URL: https://github.com/apache/airflow/pull/59872#issuecomment-3694963633
Merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #59872:
URL: https://github.com/apache/airflow/pull/59872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59872:
URL: https://github.com/apache/airflow/pull/59872#discussion_r2649823655
##########
airflow-core/pyproject.toml:
##########
@@ -77,20 +77,15 @@ dependencies = [
"argcomplete>=1.10",
"asgiref>=2.3.0",
"attrs>=22.1.0, !=25.2.0",
- "cadwyn>=5.6.2",
+ "cadwyn>=6.0.0rc1",
Review Comment:
We should wait with merging until 6.0.0 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59872:
URL: https://github.com/apache/airflow/pull/59872#issuecomment-3694862756
Still generation will have to be fixed, but let's see if Cadwyn 6.0.0rc1 fixes the basic issue https://github.com/zmievsa/cadwyn/issues/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix compatibility with FastAPI>=0.128.0 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59872:
URL: https://github.com/apache/airflow/pull/59872#discussion_r2649844918
##########
airflow-core/pyproject.toml:
##########
@@ -77,20 +77,15 @@ dependencies = [
"argcomplete>=1.10",
"asgiref>=2.3.0",
"attrs>=22.1.0, !=25.2.0",
- "cadwyn>=5.6.2",
+ "cadwyn>=6.0.0rc1",
Review Comment:
Ok. 6.0.0 released. Updated. Running tests, mergging when green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org