You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/09 20:11:58 UTC
Review Request 13446: Fixed master to properly handle TASK_LOST updates
generated by it.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13446/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-635
https://issues.apache.org/jira/browse/MESOS-635
Repository: mesos-git
Description
-------
Generated TASK_LOST updates for valid tasks are now sent via statusUpdate() instead of directly sending them. This ensures we don't miss critical stuff that needs to be done when handling terminal updates.
Diffs
-----
src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df
Diff: https://reviews.apache.org/r/13446/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13446: Fixed master to properly handle TASK_LOST updates
generated by it.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13446/#review24942
-----------------------------------------------------------
Ship it!
It does feel slightly odd that the statusUpdate() acts as both a message handler for StatusUpdateMessage, and as a helper for sending status updates generated by the master. The code appears correct but it seems odd that we simulate an incoming message in order to send a message from the master itself.
So I then thought we should set the pid to the Master's pid, but there are also some implicit semantics regarding the StatusUpdateMessage.pid, where if it is not present, the status update does not require an acknowledgement. Perhaps we should document that inside messages.proto?
- Ben Mahler
On Aug. 9, 2013, 6:45 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13446/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 6:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-635
> https://issues.apache.org/jira/browse/MESOS-635
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Generated TASK_LOST updates for valid tasks are now sent via statusUpdate() instead of directly sending them. This ensures we don't miss critical stuff that needs to be done when handling terminal updates.
>
>
> Diffs
> -----
>
> src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df
>
> Diff: https://reviews.apache.org/r/13446/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13446: Fixed master to properly handle TASK_LOST updates
generated by it.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13446/
-----------------------------------------------------------
(Updated Aug. 12, 2013, 1:02 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added a comment about StatusUpdateMessage.pid in mesos.proto. Also fixed a test to use createStatusUpdate() helper.
NNFR.
Bugs: MESOS-635
https://issues.apache.org/jira/browse/MESOS-635
Repository: mesos-git
Description
-------
Generated TASK_LOST updates for valid tasks are now sent via statusUpdate() instead of directly sending them. This ensures we don't miss critical stuff that needs to be done when handling terminal updates.
Diffs (updated)
-----
src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df
src/messages/messages.proto 19d4b387b50884f9f4a70efb3e9b739f846abf57
src/tests/fault_tolerance_tests.cpp c8d88d5f60cf49ef5c1ffa429d308c30c2e5005c
Diff: https://reviews.apache.org/r/13446/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13446: Fixed master to properly handle TASK_LOST updates
generated by it.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13446/
-----------------------------------------------------------
(Updated Aug. 9, 2013, 6:45 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
improved logging messages.
Bugs: MESOS-635
https://issues.apache.org/jira/browse/MESOS-635
Repository: mesos-git
Description
-------
Generated TASK_LOST updates for valid tasks are now sent via statusUpdate() instead of directly sending them. This ensures we don't miss critical stuff that needs to be done when handling terminal updates.
Diffs (updated)
-----
src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df
Diff: https://reviews.apache.org/r/13446/diff/
Testing
-------
make check
Thanks,
Vinod Kone