Re: [PR] Try Fix By Replacing HashSet by LinkedHashSet [pinot]

["Nemesis123925 (via GitHub)" <gi...@apache.org>]

Nemesis123925 commented on PR #12048:
URL: https://github.com/apache/pinot/pull/12048#issuecomment-1839961033

   Yes I got this part. If the issue if only about ordering of some unimportant field, it's not worthy to change the main code which influence the performance. But after testing, I found that some of the issues are not only about ordering, but about length of the two queries provided.
   
   As I run the test with `NonDex` 
   ```
   [ERROR] org.apache.pinot.queries.ExplainPlanQueriesTest.testSelectColumnsVariationsOfAndOperatorsVerbose -- Time elapsed: 0.006 s <<< FAILURE!
   java.lang.AssertionError: expected [7] but found [12]
   ```
   
   This failure is about the first line in `validateRows`, which is asserting on the `length` of generated query and expected query. Difference on this part could lead to more serious bugs, and I think also has less relation with the test code. 
   
   However I am not the expert of this project. I might have understood something wrong in the code and if there is a way to fix it without changing the main code I will definitely take it . If someone can give me more hints on this part I will be really appreciating.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org