[jira] [Commented] (FLINK-4020) Remove shard list querying from Kinesis consumer constructor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320388#comment-15320388 ] 

ASF GitHub Bot commented on FLINK-4020:
---------------------------------------

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/2081

    [FLINK-4020][streaming-connectors] Move shard list querying to open() for Kinesis consumer

    Remove shard list querying from the constructor, and let all subtasks independently discover which shards it should consume from in open(). This change is a prerequisite for [FLINK-3231](https://issues.apache.org/jira/browse/FLINK-3231).
    
    Explanation for some changes that might seem irrelevant:
    1. Changed naming of some variables / methods: Since the behaviour of shard assignment to subtasks is now (and will continue to be in the future after FLINK-3231) more like "discovering shards for consuming" instead of "being assigned shards", I've changed the "assignedShards" related namings to "discoveredShards".
    2. I've removed some tests, due to the fact that the corresponding parts of the code will be subject to quite a bit of change with the upcoming changes of [FLINK-3231](https://issues.apache.org/jira/browse/FLINK-3231). Tests will be added back with FLINK-3231.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-4020

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2081
    
----
commit 1db426be73f572aec2041cb1a9da6ad49425f392
Author: Gordon Tai <go...@vm5.com>
Date:   2016-06-08T10:46:02Z

    [FLINK-4020] Move shard list querying to open() for Kinesis consumer

----


> Remove shard list querying from Kinesis consumer constructor
> ------------------------------------------------------------
>
>                 Key: FLINK-4020
>                 URL: https://issues.apache.org/jira/browse/FLINK-4020
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming Connectors
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>
> Currently FlinkKinesisConsumer is querying for the whole list of shards in the constructor, forcing the client to be able to access Kinesis as well. This is also a drawback for handling Kinesis-side resharding, since we'd want all shard listing / shard-to-task assigning / shard end (result of resharding) handling logic to be capable of being independently done within task life cycle methods, with defined and definite results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)