You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by mu...@apache.org on 2006/06/05 21:14:55 UTC
svn commit: r411895 -
/xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInput.java
Author: mullan
Date: Mon Jun 5 12:14:54 2006
New Revision: 411895
URL: http://svn.apache.org/viewvc?rev=411895&view=rev
Log:
Fix findbugs bug:
toString() catches and ignores runtime exceptions
Modified:
xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInput.java
Modified: xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInput.java
URL: http://svn.apache.org/viewvc/xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInput.java?rev=411895&r1=411894&r2=411895&view=diff
==============================================================================
--- xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInput.java (original)
+++ xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInput.java Mon Jun 5 12:14:54 2006
@@ -390,31 +390,30 @@
}
- /**
- * Method toString
- * @inheritDoc
- *
- */
- public String toString() {
-
- if (this.isNodeSet()) {
- return "XMLSignatureInput/NodeSet/" + this._inputNodeSet.size()
+ /**
+ * Method toString
+ * @inheritDoc
+ *
+ */
+ public String toString() {
+ if (this.isNodeSet()) {
+ return "XMLSignatureInput/NodeSet/" + this._inputNodeSet.size()
+ " nodes/" + this.getSourceURI();
- }
- if (this.isElement()) {
- return "XMLSignatureInput/Element/" + this._subNode
- + " exclude "+ this.excludeNode + " comments:" +
- this.excludeComments
- +"/" + this.getSourceURI();
- }
- try {
+ }
+ if (this.isElement()) {
+ return "XMLSignatureInput/Element/" + this._subNode
+ + " exclude "+ this.excludeNode + " comments:" +
+ this.excludeComments +"/" + this.getSourceURI();
+ }
+ try {
return "XMLSignatureInput/OctetStream/" + this.getBytes().length
+ " octets/" + this.getSourceURI();
- } catch (Exception ex) {
+ } catch (IOException iex) {
return "XMLSignatureInput/OctetStream//" + this.getSourceURI();
- }
-
- }
+ } catch (CanonicalizationException cex) {
+ return "XMLSignatureInput/OctetStream//" + this.getSourceURI();
+ }
+ }
/**
* Method getHTMLRepresentation