You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by fhieber <gi...@git.apache.org> on 2016/09/14 21:20:37 UTC
[GitHub] incubator-joshua pull request #58: Moved new unit tests (former regression t...
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/58
Moved new unit tests (former regression tests) to correct location.
The previous merge from master placed the new regression tests from Michael into the wrong location. This moves them to joshua-core/src/ so that they actually get run.
Now they are failing. Can someone please investigate?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhieber/incubator-joshua 7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit ee7398f7d0c921cf1aaf7937a370a41d31431033
Author: Hieber, Felix <fh...@amazon.de>
Date: 2016-09-14T21:19:00Z
moved new unit tests (former regression tests) to correct location in joshua 7 (joshua-core/src)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/58
My guess is that grammar weights need reversing, but then I wonder why we haven't had to do that for other tests. I'll check this out later in the morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request #58: Moved new unit tests (former regression t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-joshua/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/58
Ah, right. Note that the test works from the command line:
cd $JOSHUA/joshua-core
cat src/test/resources/bn-en/hiero/input.bn | $JOSHUA/bin/joshua-decoder -c src/test/resources/bn-en/hiero/joshua.config > output
diff output src/test/resources/bn-en/hiero/output.gold
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...
Posted by fhieber <gi...@git.apache.org>.
Github user fhieber commented on the issue:
https://github.com/apache/incubator-joshua/pull/58
Depends whether we had any end-to-end tests like this already in 7. For the existing unit tests I already made the necessary changes to pass in 7. Quote from my commit for the featureFector refactoring:
> This commit also updates all existing (and enabled) Unit tests which also pass. Existing regression tests do NOT work in this commit since many of the grammars are packed and would need to be re-packed.
[Commit](https://github.com/apache/incubator-joshua/commit/20afddf85263f3def242f721728ac148ef143ad5)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---