You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/01 18:32:03 UTC
[GitHub] [tvm] manupa-arm opened a new pull request #9629: [microNPU] removing extra bytes for workspace
manupa-arm opened a new pull request #9629:
URL: https://github.com/apache/tvm/pull/9629
Given that microNPU codegen uses target hooks
it undergoes the core compiler that updates
workspace sizes. We dont need the additional
sizes anymore. This commit removes the sizes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm edited a comment on pull request #9629: [microNPU] removing extra bytes for workspace
Posted by GitBox <gi...@apache.org>.
manupa-arm edited a comment on pull request #9629:
URL: https://github.com/apache/tvm/pull/9629#issuecomment-984351612
@jroesch I think its still useful in cases where stack allocator is used in debug mode where tags are stored in the workspace itself. Thus, the workspace required would be larger than what TIR would say.
E.g. :
https://github.com/apache/tvm/blob/b4cc3ba3a29b35f89d53cfae5fc210a265bf3f7e/tests/python/relay/aot/test_crt_aot.py#L317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9629: [microNPU] removing extra bytes for workspace
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9629:
URL: https://github.com/apache/tvm/pull/9629#issuecomment-983942818
cc : @leandron @grant-arm @Mousius
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #9629: [microNPU] removing extra bytes for workspace
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #9629:
URL: https://github.com/apache/tvm/pull/9629#issuecomment-984293606
Does it make sense to remove this field all together vs. just setting it to zero?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9629: [microNPU] removing extra bytes for workspace
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9629:
URL: https://github.com/apache/tvm/pull/9629#issuecomment-984351612
@jroesch I think its still useful in cases where stack allocator is used in debug mode where tags are stored in the workspace itself. Thus, the workspace required would be larger than what TIR would say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #9629: [microNPU] removing extra bytes for workspace
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #9629:
URL: https://github.com/apache/tvm/pull/9629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org