You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/08 17:14:24 UTC
[GitHub] [kafka] ijuma opened a new pull request, #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
ijuma opened a new pull request, #12609:
URL: https://github.com/apache/kafka/pull/12609
Verified that the artifact generated by `releaseTarGz` no longer includes
swagger-jaxrs2 or its dependencies (like snakeyaml).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
C0urante commented on PR #12609:
URL: https://github.com/apache/kafka/pull/12609#issuecomment-1242086218
Filed https://github.com/apache/kafka/pull/12616 as a non-urgent follow-up to remove the combined compile-time and runtime classpath hack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
C0urante commented on code in PR #12609:
URL: https://github.com/apache/kafka/pull/12609#discussion_r967164120
##########
build.gradle:
##########
@@ -2652,7 +2653,7 @@ project(':connect:runtime') {
}
task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, dependsOn: setVersionInOpenAPISpec) {
- classpath = sourceSets.main.runtimeClasspath
+ classpath = sourceSets.main.compileClasspath
Review Comment:
~I took a stab at that with https://github.com/ijuma/kafka/pull/7. This PR looks good enough to merge as-is but if you'd like to take a look, feel free.~
Oops, never mind! This just got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #12609:
URL: https://github.com/apache/kafka/pull/12609#discussion_r966455049
##########
build.gradle:
##########
@@ -2652,7 +2653,7 @@ project(':connect:runtime') {
}
task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, dependsOn: setVersionInOpenAPISpec) {
- classpath = sourceSets.main.runtimeClasspath
+ classpath = sourceSets.main.compileClasspath
Review Comment:
The right fix may be to have a separate scope for swagger and that's basically runtimeClasspath + swagger deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
C0urante commented on code in PR #12609:
URL: https://github.com/apache/kafka/pull/12609#discussion_r967164120
##########
build.gradle:
##########
@@ -2652,7 +2653,7 @@ project(':connect:runtime') {
}
task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, dependsOn: setVersionInOpenAPISpec) {
- classpath = sourceSets.main.runtimeClasspath
+ classpath = sourceSets.main.compileClasspath
Review Comment:
I took a stab at that with https://github.com/ijuma/kafka/pull/7. This PR looks good enough to merge as-is but if you'd like to take a look, feel free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
jsancio commented on PR #12609:
URL: https://github.com/apache/kafka/pull/12609#issuecomment-1241226713
> Are we okay with spending some time on trying to fix the docs generation, or does this need to be merged ASAP to unblock the 3.3 release?
@C0urante I am open to suggestions on how to fix this. We have a couple of days to fix the issue. Do you have time to look into this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio merged pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
jsancio merged PR #12609:
URL: https://github.com/apache/kafka/pull/12609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
C0urante commented on PR #12609:
URL: https://github.com/apache/kafka/pull/12609#issuecomment-1241229865
Yeah, I can try to find something. Thanks José!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
jsancio commented on PR #12609:
URL: https://github.com/apache/kafka/pull/12609#issuecomment-1240998511
Thanks for the PR @ijuma . What do think @showuon @C0urante @mimaison?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
C0urante commented on PR #12609:
URL: https://github.com/apache/kafka/pull/12609#issuecomment-1241219303
This appears to break the docs generation added in https://github.com/apache/kafka/pull/12067; running `./gradlew siteDocsTar` with this change causes the generated `docs/generated/connect_rest.yaml` file to lose all information on the REST API save for general metadata.
Are we okay with spending some time on trying to fix the docs generation, or does this need to be merged ASAP to unblock the 3.3 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
C0urante commented on code in PR #12609:
URL: https://github.com/apache/kafka/pull/12609#discussion_r966438130
##########
build.gradle:
##########
@@ -2652,7 +2653,7 @@ project(':connect:runtime') {
}
task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, dependsOn: setVersionInOpenAPISpec) {
- classpath = sourceSets.main.runtimeClasspath
+ classpath = sourceSets.main.compileClasspath
Review Comment:
This feels like a terrible hack but by combining the runtime and compile classpaths, we can still generate the correct docs with `siteDocsTar` and omit the unnecessary Swagger dependencies from the release artifact generated with `releaseTarGz`:
```suggestion
classpath = sourceSets.main.compileClasspath + sourceSets.main.runtimeClasspath
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly
Posted by GitBox <gi...@apache.org>.
jsancio commented on code in PR #12609:
URL: https://github.com/apache/kafka/pull/12609#discussion_r966451504
##########
build.gradle:
##########
@@ -2652,7 +2653,7 @@ project(':connect:runtime') {
}
task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, dependsOn: setVersionInOpenAPISpec) {
- classpath = sourceSets.main.runtimeClasspath
+ classpath = sourceSets.main.compileClasspath
Review Comment:
I am okay with this fix. Feel free to create a Jira to have a better fix beyond 3.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org