You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/07/28 13:10:00 UTC

[jira] [Commented] (IMPALA-11446) push down NOT_IN predicate to iceberg

    [ https://issues.apache.org/jira/browse/IMPALA-11446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572443#comment-17572443 ] 

ASF subversion and git services commented on IMPALA-11446:
----------------------------------------------------------

Commit 614dc54dcc14687a11bb64495d4b6d4356ef55fc in impala's branch refs/heads/master from LPL
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=614dc54dc ]

IMPALA-11446: Push-down NOT_IN predicate to iceberg

Because the column value bounds of the Iceberg meta are not necessarily
a min or max value, NOT_IN cannot be answered using them.
NOT_IN(col, {X, ...}) with (X, Y) doesn't guarantee that X is a value
in col. But it works when the push-down column is the partition column,
it's still very helpful.

Testing:
  - add e2e tests

Change-Id: Ib8bdaf6f31a4438e11c4eb27485bb413fe6df9a3
Reviewed-on: http://gerrit.cloudera.org:8080/18760
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> push down NOT_IN predicate to iceberg
> -------------------------------------
>
>                 Key: IMPALA-11446
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11446
>             Project: IMPALA
>          Issue Type: Sub-task
>            Reporter: LiPenglin
>            Assignee: LiPenglin
>            Priority: Major
>
> Since 'org.apache.iceberg.expressions.InclusiveMetricsEvaluator.MetricsEvalVisitor#notIn' [https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java#L370] always returns 'ROWS_MIGHT_MATCH', the push-down of NOT_IN was not implemented at that time, but NOT_IN works when the column is a partitioned column, it's still very helpful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org