You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "azexcy (via GitHub)" <gi...@apache.org> on 2023/02/17 09:14:31 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #24218: Remove CDC rule, move CDC config into server properties
azexcy opened a new pull request, #24218:
URL: https://github.com/apache/shardingsphere/pull/24218
Changes proposed in this pull request:
- Remove CDC rule
- Move CDC config into server properties
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24218: Remove CDC rule, move CDC config into server properties
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24218:
URL: https://github.com/apache/shardingsphere/pull/24218#issuecomment-1434559481
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24218](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5938c52) into [master](https://codecov.io/gh/apache/shardingsphere/commit/739e761349087b7401e5448a971516613d0c0f03?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (739e761) will **decrease** coverage by `0.12%`.
> The diff coverage is `44.23%`.
> :exclamation: Current head 5938c52 differs from pull request most recent head d4b7e83. Consider uploading reports for the commit d4b7e83 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24218 +/- ##
============================================
- Coverage 50.13% 50.01% -0.12%
+ Complexity 1580 1575 -5
============================================
Files 3256 3250 -6
Lines 53515 53410 -105
Branches 9870 9859 -11
============================================
- Hits 26830 26714 -116
- Misses 24323 24335 +12
+ Partials 2362 2361 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ngsphere/data/pipeline/cdc/api/impl/CDCJobAPI.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2FwaS9pbXBsL0NEQ0pvYkFQSS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...a/pipeline/cdc/config/job/CDCJobConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvbmZpZy9qb2IvQ0RDSm9iQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...proxy/backend/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `56.60% <ø> (+2.05%)` | :arrow_up: |
| [...kend/config/yaml/YamlProxyServerConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcveWFtbC9ZYW1sUHJveHlTZXJ2ZXJDb25maWd1cmF0aW9uLmphdmE=) | `55.55% <ø> (ø)` | |
| [...e/proxy/backend/handler/cdc/CDCBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2NkYy9DRENCYWNrZW5kSGFuZGxlci5qYXZh) | `24.73% <0.00%> (ø)` | |
| [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `64.00% <0.00%> (-2.67%)` | :arrow_down: |
| [...tsql/ral/UpdatableGlobalRuleRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1VwZGF0YWJsZUdsb2JhbFJ1bGVSQUxCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...dc/core/connector/SocketSinkImporterConnector.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvY29ubmVjdG9yL1NvY2tldFNpbmtJbXBvcnRlckNvbm5lY3Rvci5qYXZh) | `15.55% <15.38%> (ø)` | |
| [...ler/update/AlterSQLParserRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3BhcnNlci9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3BhcnNlci9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0FsdGVyU1FMUGFyc2VyUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `33.33% <33.33%> (-29.17%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/shardingsphere/pull/24218?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #24218: Remove CDC rule, move CDC config into server properties
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on code in PR #24218:
URL: https://github.com/apache/shardingsphere/pull/24218#discussion_r1111407763
##########
proxy/bootstrap/src/main/java/org/apache/shardingsphere/proxy/Bootstrap.java:
##########
@@ -51,10 +52,8 @@ public static void main(final String[] args) throws IOException, SQLException {
int port = bootstrapArgs.getPort().orElseGet(() -> new ConfigurationProperties(yamlConfig.getServerConfiguration().getProps()).getValue(ConfigurationPropertyKey.PROXY_DEFAULT_PORT));
List<String> addresses = bootstrapArgs.getAddresses();
new BootstrapInitializer().init(yamlConfig, port, bootstrapArgs.getForce());
- boolean cdcEnabled = null != yamlConfig.getServerConfiguration().getCdc() && yamlConfig.getServerConfiguration().getCdc().isEnabled();
- if (cdcEnabled) {
- new CDCServer(addresses, yamlConfig.getServerConfiguration().getCdc().getPort()).start();
- }
+ Optional.ofNullable((Integer) yamlConfig.getServerConfiguration().getProps().get(ConfigurationPropertyKey.CDC_SERVER_PORT.getKey()))
+ .ifPresent(cdcPort -> new CDCServer(addresses, cdcPort).start());
Review Comment:
Will start CDC server throw exception? If true, then it might need to catch and ignore it
##########
infra/common/src/main/java/org/apache/shardingsphere/infra/config/props/ConfigurationPropertyKey.java:
##########
@@ -122,7 +122,12 @@ public enum ConfigurationPropertyKey implements TypedPropertyKey {
/**
* Proxy instance type.
*/
- PROXY_INSTANCE_TYPE("proxy-instance-type", "Proxy", String.class, true);
+ PROXY_INSTANCE_TYPE("proxy-instance-type", "Proxy", String.class, true),
+
+ /**
+ * CDC server port.
+ */
+ CDC_SERVER_PORT("cdc-server-port", "33071", int.class, true);
Review Comment:
Currently, reboot is required after `cdc-server-port` changed, it might be not required later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #24218: Remove CDC rule, move CDC config into server properties
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #24218:
URL: https://github.com/apache/shardingsphere/pull/24218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on a diff in pull request #24218: Remove CDC rule, move CDC config into server properties
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on code in PR #24218:
URL: https://github.com/apache/shardingsphere/pull/24218#discussion_r1111413457
##########
infra/common/src/main/java/org/apache/shardingsphere/infra/config/props/ConfigurationPropertyKey.java:
##########
@@ -122,7 +122,12 @@ public enum ConfigurationPropertyKey implements TypedPropertyKey {
/**
* Proxy instance type.
*/
- PROXY_INSTANCE_TYPE("proxy-instance-type", "Proxy", String.class, true);
+ PROXY_INSTANCE_TYPE("proxy-instance-type", "Proxy", String.class, true),
+
+ /**
+ * CDC server port.
+ */
+ CDC_SERVER_PORT("cdc-server-port", "33071", int.class, true);
Review Comment:
Yes, it is possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org