You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/06/07 23:01:30 UTC
[GitHub] [incubator-pinot] tdunning opened a new pull request #7029: Upgrade t-digest to latest release
tdunning opened a new pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029
## Description
<!-- Add a description of your PR here.
A good description should include pointers to an issue or design document, etc.
-->
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv removed a comment on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
mayankshriv removed a comment on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860828570
Ted, I have re-launched the tests. Typically an update of your branch will relaunch it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860858846
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7029](https://codecov.io/gh/apache/incubator-pinot/pull/7029?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b12f3f) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/a1c9b631381a25ddd6d3164d6a9ce337c3939b9f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1c9b63) will **decrease** coverage by `7.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/7029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7029 +/- ##
============================================
- Coverage 73.38% 65.44% -7.95%
Complexity 12 12
============================================
Files 1453 1453
Lines 72032 72032
Branches 10427 10427
============================================
- Hits 52863 47140 -5723
- Misses 15643 21493 +5850
+ Partials 3526 3399 -127
```
| Flag | Coverage Δ | |
|---|---|---|
| integration | `?` | |
| unittests | `65.44% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/7029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/pinot/minion/metrics/MinionMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/minion/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pache/pinot/common/utils/grpc/GrpcQueryClient.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvZ3JwYy9HcnBjUXVlcnlDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pinot/minion/exception/TaskCancelledException.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhjZXB0aW9uL1Rhc2tDYW5jZWxsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t/core/startree/plan/StarTreeDocIdSetPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9wbGFuL1N0YXJUcmVlRG9jSWRTZXRQbGFuTm9kZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../core/startree/plan/StarTreeTransformPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9wbGFuL1N0YXJUcmVlVHJhbnNmb3JtUGxhbk5vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...core/startree/plan/StarTreeProjectionPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9wbGFuL1N0YXJUcmVlUHJvamVjdGlvblBsYW5Ob2RlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t/minion/executor/MinionTaskZkMetadataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvTWluaW9uVGFza1prTWV0YWRhdGFNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...startree/executor/StarTreeAggregationExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9leGVjdXRvci9TdGFyVHJlZUFnZ3JlZ2F0aW9uRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [337 more](https://codecov.io/gh/apache/incubator-pinot/pull/7029/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7029?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7029?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e91f426...0b12f3f](https://codecov.io/gh/apache/incubator-pinot/pull/7029?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv merged pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
mayankshriv merged pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] tdunning commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
tdunning commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856409675
Good suggestion.
This blog is the high-level view, I will collect a more formal release note.
On Mon, Jun 7, 2021 at 4:28 PM Mayank Shrivastava ***@***.***>
wrote:
> A link to release notes on TDigest side would be handy to include in the
> PR description.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856326715>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAB5E6XOGYCZ4G3C362D6VDTRVI3HANCNFSM46IUMOPA>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856326505
Restarted tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860829270
@tdunning, I have relaunched the tests. Typically an update in your branch will relaunch them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] tdunning commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
tdunning commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860384640
OK. The artifacts on maven central are now complete and correct.
The demo program at `https://github.com/tdunning/t-digest-example` builds on a clean machine which should mean that Pinot itself should build cleanly.
How can we relaunch the integration tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856919437
> OK. I understand this now. The problem is that I did an incompetent job of breaking t-digest into multiple modules. This meant that I needed to publish the parent pom as an artifact. I will have to recut the release. Should get that out in a day or two.
Thanks @tdunning, much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856327150
Hmm, seems like a real build failure: ```Failed to execute goal on project pinot-segment-local: Could not resolve dependencies for project org.apache.pinot:pinot-segment-local:jar:0.8.0-SNAPSHOT: Failed to collect dependencies at com.tdunning:t-digest:jar:3.3: Failed to read artifact descriptor for com.tdunning:t-digest:jar:3.3: Could not find artifact com.tdunning:t-digest-parent:pom:3.3 in central (https://repo.maven.apache.org/maven2)```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] tdunning commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
tdunning commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856410752
I meant this blog.
https://tdunning.blogspot.com/2021/06/whats-new-in-t-digest-new-version-32.html
On Mon, Jun 7, 2021 at 8:27 PM Ted Dunning ***@***.***> wrote:
>
> Good suggestion.
>
> This blog is the high-level view, I will collect a more formal release
> note.
>
>
> On Mon, Jun 7, 2021 at 4:28 PM Mayank Shrivastava <
> ***@***.***> wrote:
>
>> A link to release notes on TDigest side would be handy to include in the
>> PR description.
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856326715>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AAB5E6XOGYCZ4G3C362D6VDTRVI3HANCNFSM46IUMOPA>
>> .
>>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] tdunning commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
tdunning commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860848772
Cool.
The change here is a new artifact in maven central so your manual restart
was just the thing.
On Mon, Jun 14, 2021 at 9:42 AM Mayank Shrivastava ***@***.***>
wrote:
> @tdunning <https://github.com/tdunning>, I have relaunched the tests.
> Typically an update in your branch will relaunch them.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860829270>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAB5E6S4G3B3ZQIL7QXHNE3TSYWPDANCNFSM46IUMOPA>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] tdunning edited a comment on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
tdunning edited a comment on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860384640
OK. The artifacts on maven central are now complete and correct. No changes to existing artifacts were needed so Pinot can continue with the t-digest version 3.3.
The demo program at `https://github.com/tdunning/t-digest-example` builds on a clean machine which should mean that Pinot itself should build cleanly.
How can we relaunch the integration tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856326715
A link to release notes on TDigest side would be handy to include in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] tdunning commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
tdunning commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856410508
This is very odd. If I look in
https://repo.maven.apache.org/maven2/com/tdunning/t-digest/3.3
I see the artifacts.
Is there a cache messing you about?
On Mon, Jun 7, 2021 at 4:30 PM Mayank Shrivastava ***@***.***>
wrote:
> Hmm, seems like a real build failure: Failed to execute goal on project
> pinot-segment-local: Could not resolve dependencies for project
> org.apache.pinot:pinot-segment-local:jar:0.8.0-SNAPSHOT: Failed to collect
> dependencies at com.tdunning:t-digest:jar:3.3: Failed to read artifact
> descriptor for com.tdunning:t-digest:jar:3.3: Could not find artifact
> com.tdunning:t-digest-parent:pom:3.3 in central (
> https://repo.maven.apache.org/maven2)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856327150>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAB5E6W6SUVZWIZ2LYTQHLTTRVJADANCNFSM46IUMOPA>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-860828570
Ted, I have re-launched the tests. Typically an update of your branch will relaunch it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] tdunning commented on pull request #7029: Upgrade t-digest to latest release
Posted by GitBox <gi...@apache.org>.
tdunning commented on pull request #7029:
URL: https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856494966
OK. I understand this now.
The problem is that I did an incompetent job of breaking t-digest into
multiple modules. This meant that I needed to publish the parent pom as an
artifact.
I will have to recut the release. Should get that out in a day or two.
On Mon, Jun 7, 2021 at 4:30 PM Mayank Shrivastava ***@***.***>
wrote:
> Hmm, seems like a real build failure: Failed to execute goal on project
> pinot-segment-local: Could not resolve dependencies for project
> org.apache.pinot:pinot-segment-local:jar:0.8.0-SNAPSHOT: Failed to collect
> dependencies at com.tdunning:t-digest:jar:3.3: Failed to read artifact
> descriptor for com.tdunning:t-digest:jar:3.3: Could not find artifact
> com.tdunning:t-digest-parent:pom:3.3 in central (
> https://repo.maven.apache.org/maven2)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pinot/pull/7029#issuecomment-856327150>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAB5E6W6SUVZWIZ2LYTQHLTTRVJADANCNFSM46IUMOPA>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org