You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/18 01:25:37 UTC

[GitHub] [airflow] dstandish commented on a change in pull request #7753: [AIRFLOW-5705] Make AwsSsmSecretsBackend consistent with VaultBackend

dstandish commented on a change in pull request #7753: [AIRFLOW-5705] Make AwsSsmSecretsBackend consistent with VaultBackend
URL: https://github.com/apache/airflow/pull/7753#discussion_r394057083
 
 

 ##########
 File path: airflow/providers/amazon/aws/secrets/ssm.py
 ##########
 @@ -21,9 +21,10 @@
 from typing import List, Optional
 
 import boto3
+from cached_property import cached_property
 
 from airflow.models import Connection
-from airflow.secrets import CONN_ENV_PREFIX, BaseSecretsBackend
 
 Review comment:
   `CONN_ENV_PREFIX` should probably be moved to `airflow/secrets/environment_variables.py` since it is no longer a shared pattern, but something specific to the env vars backend...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services