You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Ankeet Maini <an...@gmail.com> on 2015/08/19 09:09:08 UTC
Re: Review Request 37530: LENS-629 - A new improved web client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Aug. 19, 2015, 7:09 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs
-----
lens-ui/.gitignore PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95937
-----------------------------------------------------------
lens-ui/README.markdown (line 5)
<https://reviews.apache.org/r/37530/#comment151133>
Update it as its measures and dim attributes
- Amareshwari Sriramadasu
On Aug. 20, 2015, 9:38 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2015, 9:38 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore d0fa424
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99921
-----------------------------------------------------------
pom.xml (line 111)
<https://reviews.apache.org/r/37530/#comment156932>
I think we are already using 1.8, this would be conflicting.
- Amareshwari Sriramadasu
On Sept. 21, 2015, 12:14 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 12:14 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 7:44 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Reverting unintended src/site/apt/admin/config.apt modifications
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml 10f9bc1
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 7:40 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Fixes POM typo/.
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml 10f9bc1
src/site/apt/admin/config.apt 3500441
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 10:09 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Changed localhost to 0.0.0.0
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml adba544
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99945
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Sept. 22, 2015, 6:34 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:34 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Sept. 22, 2015, 9:37 a.m., Rajat Khandelwal wrote:
> > lens-ui/package.json, line 7
> > <https://reviews.apache.org/r/37530/diff/11-12/?file=1079934#file1079934line7>
> >
> > Can we change `localhost` everywhere to `0.0.0.0`?
> >
> > I think Lens server also listens on all interfaces instead of just loopback.
Done. Updated diff.
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99961
-----------------------------------------------------------
On Sept. 22, 2015, 10:09 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 10:09 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99961
-----------------------------------------------------------
lens-ui/package.json (line 7)
<https://reviews.apache.org/r/37530/#comment157010>
Can we change `localhost` everywhere to `0.0.0.0`?
I think Lens server also listens on all interfaces instead of just loopback.
- Rajat Khandelwal
On Sept. 22, 2015, 12:04 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 12:04 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 6:34 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
1. Updates README about information to customize port number.
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml adba544
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 6:24 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Removes duplicate antrun plugin.
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml adba544
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
Please can someone quickly see and approve? I've another big patch almost
ready for saved/parametrized queries.
On Mon, Sep 21, 2015 at 5:44 PM, Ankeet Maini <an...@gmail.com>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat
> Khandelwal, sharad agarwal, and Yash Sharma.
> By Ankeet Maini.
>
> *Updated Sept. 21, 2015, 12:14 p.m.*
> Changes
>
> 1. POM versions mpoved to parent.
> 2. assets moved to target.
>
> *Bugs: * LENS-629 <https://issues.apache.org/jira/browse/LENS-629>
> *Repository: * lens
> Description
>
> LENS-629 - A new improved web client
>
> Testing
>
> No server code added/modified. Just JavaScript!
>
> Diffs (updated)
>
> - .gitignore (5a356e0)
> - lens-ui/LICENSE (PRE-CREATION)
> - lens-ui/README.markdown (PRE-CREATION)
> - lens-ui/app/actions/AdhocQueryActions.js (PRE-CREATION)
> - lens-ui/app/actions/LoginActions.js (PRE-CREATION)
> - lens-ui/app/adapters/AdhocQueryAdapter.js (PRE-CREATION)
> - lens-ui/app/adapters/AuthenticationAdapter.js (PRE-CREATION)
> - lens-ui/app/adapters/BaseAdapter.js (PRE-CREATION)
> - lens-ui/app/app.js (PRE-CREATION)
> - lens-ui/app/components/AboutComponent.js (PRE-CREATION)
> - lens-ui/app/components/AdhocQueryComponent.js (PRE-CREATION)
> - lens-ui/app/components/AppComponent.js (PRE-CREATION)
> - lens-ui/app/components/CubeSchemaComponent.js (PRE-CREATION)
> - lens-ui/app/components/CubeTreeComponent.js (PRE-CREATION)
> - lens-ui/app/components/DatabaseComponent.js (PRE-CREATION)
> - lens-ui/app/components/HeaderComponent.js (PRE-CREATION)
> - lens-ui/app/components/LoaderComponent.js (PRE-CREATION)
> - lens-ui/app/components/LoginComponent.js (PRE-CREATION)
> - lens-ui/app/components/LogoutComponent.js (PRE-CREATION)
> - lens-ui/app/components/QueryBoxComponent.js (PRE-CREATION)
> - lens-ui/app/components/QueryDetailResultComponent.js (PRE-CREATION)
> - lens-ui/app/components/QueryOperationsComponent.js (PRE-CREATION)
> - lens-ui/app/components/QueryPreviewComponent.js (PRE-CREATION)
> - lens-ui/app/components/QueryResultsComponent.js (PRE-CREATION)
> - lens-ui/app/components/RequireAuthenticationComponent.js
> (PRE-CREATION)
> - lens-ui/app/components/SidebarComponent.js (PRE-CREATION)
> - lens-ui/app/components/TableSchemaComponent.js (PRE-CREATION)
> - lens-ui/app/components/TableTreeComponent.js (PRE-CREATION)
> - lens-ui/app/constants/AdhocQueryConstants.js (PRE-CREATION)
> - lens-ui/app/constants/AppConstants.js (PRE-CREATION)
> - lens-ui/app/dispatcher/AppDispatcher.js (PRE-CREATION)
> - lens-ui/app/stores/AdhocQueryStore.js (PRE-CREATION)
> - lens-ui/app/stores/CubeStore.js (PRE-CREATION)
> - lens-ui/app/stores/DatabaseStore.js (PRE-CREATION)
> - lens-ui/app/stores/TableStore.js (PRE-CREATION)
> - lens-ui/app/stores/UserStore.js (PRE-CREATION)
> - lens-ui/app/styles/css/global.css (PRE-CREATION)
> - lens-ui/app/styles/css/login.css (PRE-CREATION)
> - lens-ui/app/styles/css/query-component.css (PRE-CREATION)
> - lens-ui/app/styles/css/tree.css (PRE-CREATION)
> - lens-ui/app/styles/less/globals.less (PRE-CREATION)
> - lens-ui/config.json (PRE-CREATION)
> - lens-ui/index.html (PRE-CREATION)
> - lens-ui/package.json (PRE-CREATION)
> - lens-ui/pom.xml (PRE-CREATION)
> - lens-ui/server.js (PRE-CREATION)
> - lens-ui/webpack.config.js (PRE-CREATION)
> - pom.xml (adba544)
>
> View Diff <https://reviews.apache.org/r/37530/diff/>
> File Attachments
> - License details of NPM packages
> <https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt>
>
--
*Ankeet Maini*
*"Just when the caterpillar thought the world was over, it became a
butterfly!"*
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 21, 2015, 12:14 p.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
1. POM versions mpoved to parent.
2. assets moved to target.
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml adba544
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Sept. 19, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote:
> > pom.xml, lines 550-552
> > <https://reviews.apache.org/r/37530/diff/9/?file=1077457#file1077457line550>
> >
> > Can these folders be moved to target/ ? Otherwise, how will they get cleaned up in next build?
Only assets can be moved inside target folder which contains the bundled, minified and transpiled source files which is under my control.
As to node_modules, it is used by Node package manager to look the dependencies, and other dependencies also look inside it to find its dependencies in a recursive manner. So it can't be changed. It's also cited here in the npm FAQ https://docs.npmjs.com/misc/faq#node-modules-is-the-name-of-my-deity-s-arch-rival-and-a-forbidden-word-in-my-religion-can-i-configure-npm-to-use-a-different-folder
Also we would not want to move node folder which contains the node js installation files. If we were to change that, after every mvn clean install, the maven goal would download the entire node package which would be too costly and time consuming affair. This node folder would be created by the maven plugin(frontend-maven-plugin) to install nodejs locally while doing an mvn compile, so that nodejs is not a prerequisite for backend developers as it earlier was. It'll not conflict with any existing installation and will be available only locally.
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99666
-----------------------------------------------------------
On Sept. 19, 2015, 8:44 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 8:44 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Sept. 19, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/pom.xml, lines 58-59
> > <https://reviews.apache.org/r/37530/diff/9/?file=1077454#file1077454line58>
> >
> > Can these be defined in parent pom?
Yes.
> On Sept. 19, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote:
> > pom.xml, lines 550-552
> > <https://reviews.apache.org/r/37530/diff/9/?file=1077457#file1077457line550>
> >
> > Can these folders be moved to target/ ? Otherwise, how will they get cleaned up in next build?
>
> Ankeet Maini wrote:
> Only assets can be moved inside target folder which contains the bundled, minified and transpiled source files which is under my control.
>
> As to node_modules, it is used by Node package manager to look the dependencies, and other dependencies also look inside it to find its dependencies in a recursive manner. So it can't be changed. It's also cited here in the npm FAQ https://docs.npmjs.com/misc/faq#node-modules-is-the-name-of-my-deity-s-arch-rival-and-a-forbidden-word-in-my-religion-can-i-configure-npm-to-use-a-different-folder
>
> Also we would not want to move node folder which contains the node js installation files. If we were to change that, after every mvn clean install, the maven goal would download the entire node package which would be too costly and time consuming affair. This node folder would be created by the maven plugin(frontend-maven-plugin) to install nodejs locally while doing an mvn compile, so that nodejs is not a prerequisite for backend developers as it earlier was. It'll not conflict with any existing installation and will be available only locally.
Moved the assets folder to target. Updated patch.
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99666
-----------------------------------------------------------
On Sept. 22, 2015, 6:24 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:24 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Sept. 19, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/README.markdown, lines 35-36
> > <https://reviews.apache.org/r/37530/diff/9/?file=1077412#file1077412line35>
> >
> > Does this require changes after mavenizing now ?
Now no need for ```npm install```.
Updated and uploaded the new diff patch
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99666
-----------------------------------------------------------
On Sept. 22, 2015, 6:34 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:34 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99666
-----------------------------------------------------------
lens-ui/README.markdown (lines 35 - 36)
<https://reviews.apache.org/r/37530/#comment156627>
Does this require changes after mavenizing now ?
lens-ui/pom.xml (line 40)
<https://reviews.apache.org/r/37530/#comment156628>
Please dont define versions here. Move all version definitions to parent pom
lens-ui/pom.xml (line 50)
<https://reviews.apache.org/r/37530/#comment156629>
Move version definition to parent pom
lens-ui/pom.xml (lines 58 - 59)
<https://reviews.apache.org/r/37530/#comment156630>
Can these be defined in parent pom?
pom.xml (lines 550 - 552)
<https://reviews.apache.org/r/37530/#comment156625>
Can these folders be moved to target/ ? Otherwise, how will they get cleaned up in next build?
- Amareshwari Sriramadasu
On Sept. 19, 2015, 8:44 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 8:44 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 19, 2015, 8:44 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Uploaded a new diff, as earlier one wasn't working as cited by Amareshwari in Jira ticket.
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml adba544
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 10:28 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Indents pom.xml, removes unnecessary whitespaces.
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml adba544
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99393
-----------------------------------------------------------
lens-ui/pom.xml (line 50)
<https://reviews.apache.org/r/37530/#comment156281>
remove redundant space
- Rajat Khandelwal
On Sept. 17, 2015, 5:49 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 5:49 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 17, 2015, 12:19 p.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
1. Mavenized the Lens UI package.
2. Customizable port number
3. All dependencies will be downloaded along with NodeJS locally by mvn compile/install/package
4. Need only do ```npm run start``` from lens/lens-ui to start the app.
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore 5a356e0
lens-ui/LICENSE PRE-CREATION
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/pom.xml PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
pom.xml adba544
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Sept. 1, 2015, 5:30 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs
-----
.gitignore d0fa424
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Sept. 1, 2015, 5:29 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 1
> > <https://reviews.apache.org/r/37530/diff/6/?file=1048619#file1048619line1>
> >
> > Same as earlier. Can you include license header with json commnents?
We cannot add comments to a json file. https://plus.google.com/+DouglasCrockfordEsq/posts/RK8qyGVaGSr
One is config.json, which I can rename to config.data but package.json can't be renamed as it is looked up by npm (Node package manager) analogous to mvn which looks for pom.xml.
So can we add an exception in the rules to ignore .json files?
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review97254
-----------------------------------------------------------
On Sept. 1, 2015, 5:30 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 5:30 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore d0fa424
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Sept. 1, 2015, 5:29 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 1
> > <https://reviews.apache.org/r/37530/diff/6/?file=1048619#file1048619line1>
> >
> > Same as earlier. Can you include license header with json commnents?
>
> Ankeet Maini wrote:
> We cannot add comments to a json file. https://plus.google.com/+DouglasCrockfordEsq/posts/RK8qyGVaGSr
>
> One is config.json, which I can rename to config.data but package.json can't be renamed as it is looked up by npm (Node package manager) analogous to mvn which looks for pom.xml.
>
> So can we add an exception in the rules to ignore .json files?
Added an exception for the rat check.
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review97254
-----------------------------------------------------------
On Sept. 17, 2015, 12:19 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 12:19 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review97254
-----------------------------------------------------------
lens-ui/README.markdown (line 1)
<https://reviews.apache.org/r/37530/#comment153077>
Can you include license header?
lens-ui/config.json (line 1)
<https://reviews.apache.org/r/37530/#comment153078>
Can you include license header? Can we use json comments here for license?
lens-ui/package.json (line 1)
<https://reviews.apache.org/r/37530/#comment153079>
Same as earlier. Can you include license header with json commnents?
lens-ui/package.json (line 7)
<https://reviews.apache.org/r/37530/#comment153076>
Can you change this to localhost:9999/lensapi ?
lens-ui/server.js (line 72)
<https://reviews.apache.org/r/37530/#comment153084>
Can the port 8082 be configurable?
- Amareshwari Sriramadasu
On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 6:45 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore d0fa424
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 6:45 p.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Adds missing licenses, also adding another file which lists all the license details of npm packages used by the app.
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore d0fa424
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
File Attachments (updated)
----------------
License details of NPM packages
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Aug. 20, 2015, 7:06 p.m., Ajay Yadava wrote:
> > lens-ui/README.markdown, line 24
> > <https://reviews.apache.org/r/37530/diff/5/?file=1045044#file1045044line24>
> >
> > You can use Maven frontend plugin (https://github.com/eirslett/frontend-maven-plugin) to integrate it with maven.
I'll check this out. And update!
> On Aug. 20, 2015, 7:06 p.m., Ajay Yadava wrote:
> > lens-ui/package.json, line 17
> > <https://reviews.apache.org/r/37530/diff/5/?file=1045085#file1045085line17>
> >
> > https://github.com/STRML/keyMirror doesn't contain license info, not sure about it's usage.
It's open-source only. And freely distributed.
> On Aug. 20, 2015, 7:06 p.m., Ajay Yadava wrote:
> > lens-ui/server.js, line 24
> > <https://reviews.apache.org/r/37530/diff/5/?file=1045086#file1045086line24>
> >
> > Shouldn't the console.log().. statements be removed? It is not guaranteed to be defined in all browsers at all times.
It'll always run in node environment and will be present. It helps the user to know on which port the app will run. I can remove this too. But it's harmless.
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95985
-----------------------------------------------------------
On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 6:45 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore d0fa424
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Aug. 20, 2015, 7:06 p.m., Ajay Yadava wrote:
> > lens-ui/README.markdown, line 24
> > <https://reviews.apache.org/r/37530/diff/5/?file=1045044#file1045044line24>
> >
> > You can use Maven frontend plugin (https://github.com/eirslett/frontend-maven-plugin) to integrate it with maven.
>
> Ankeet Maini wrote:
> I'll check this out. And update!
Done :)
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95985
-----------------------------------------------------------
On Sept. 17, 2015, 12:19 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 12:19 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95985
-----------------------------------------------------------
lens-ui/README.markdown (line 24)
<https://reviews.apache.org/r/37530/#comment151185>
You can use Maven frontend plugin (https://github.com/eirslett/frontend-maven-plugin) to integrate it with maven.
lens-ui/app/components/AboutComponent.js (line 1)
<https://reviews.apache.org/r/37530/#comment151182>
License header is missing.
lens-ui/app/styles/css/login.css (line 1)
<https://reviews.apache.org/r/37530/#comment151189>
Missing license header.
lens-ui/app/styles/css/tree.css (line 1)
<https://reviews.apache.org/r/37530/#comment151188>
Missing license header.
lens-ui/index.html (line 1)
<https://reviews.apache.org/r/37530/#comment151179>
I think others have already mentioned the need for license headers in Javascript files but apart from them HTML files should also contain license headers.
lens-ui/package.json (line 17)
<https://reviews.apache.org/r/37530/#comment151186>
https://github.com/STRML/keyMirror doesn't contain license info, not sure about it's usage.
lens-ui/server.js (line 1)
<https://reviews.apache.org/r/37530/#comment151187>
Missing license header.
lens-ui/server.js (line 24)
<https://reviews.apache.org/r/37530/#comment151177>
Shouldn't the console.log().. statements be removed? It is not guaranteed to be defined in all browsers at all times.
- Ajay Yadava
On Aug. 20, 2015, 9:38 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2015, 9:38 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore d0fa424
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Aug. 20, 2015, 9:38 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Small update to README
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore d0fa424
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Aug. 20, 2015, 9:28 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Changes
-------
Added a new patch with licenses. Removed author information and removed .gitignore file from lens-ui in favour of the parent module.
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore d0fa424
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
-----------------------------------------------------------
(Updated Aug. 20, 2015, 9:25 a.m.)
Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
Repository: lens
Description
-------
LENS-629 - A new improved web client
Diffs (updated)
-----
.gitignore d0fa424
lens-ui/README.markdown PRE-CREATION
lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
lens-ui/app/actions/LoginActions.js PRE-CREATION
lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
lens-ui/app/app.js PRE-CREATION
lens-ui/app/components/AboutComponent.js PRE-CREATION
lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
lens-ui/app/components/AppComponent.js PRE-CREATION
lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
lens-ui/app/components/DatabaseComponent.js PRE-CREATION
lens-ui/app/components/HeaderComponent.js PRE-CREATION
lens-ui/app/components/LoaderComponent.js PRE-CREATION
lens-ui/app/components/LoginComponent.js PRE-CREATION
lens-ui/app/components/LogoutComponent.js PRE-CREATION
lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
lens-ui/app/components/SidebarComponent.js PRE-CREATION
lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
lens-ui/app/components/TableTreeComponent.js PRE-CREATION
lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
lens-ui/app/constants/AppConstants.js PRE-CREATION
lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
lens-ui/app/stores/CubeStore.js PRE-CREATION
lens-ui/app/stores/DatabaseStore.js PRE-CREATION
lens-ui/app/stores/TableStore.js PRE-CREATION
lens-ui/app/stores/UserStore.js PRE-CREATION
lens-ui/app/styles/css/global.css PRE-CREATION
lens-ui/app/styles/css/login.css PRE-CREATION
lens-ui/app/styles/css/query-component.css PRE-CREATION
lens-ui/app/styles/css/tree.css PRE-CREATION
lens-ui/app/styles/less/globals.less PRE-CREATION
lens-ui/config.json PRE-CREATION
lens-ui/index.html PRE-CREATION
lens-ui/package.json PRE-CREATION
lens-ui/server.js PRE-CREATION
lens-ui/webpack.config.js PRE-CREATION
Diff: https://reviews.apache.org/r/37530/diff/
Testing
-------
No server code added/modified. Just JavaScript!
Thanks,
Ankeet Maini
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Aug. 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 12
> > <https://reviews.apache.org/r/37530/diff/2/?file=1041996#file1041996line12>
> >
> > How are these dependencies downloaded?
> >
> > Can you also update license of each of the dependency here for us to check with apache compatibility.
>
> Ankeet Maini wrote:
> These dependencies are downloaded by npm (Node Package Manager). These are the licenses which the app uses *(LICENSES: Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, CC-BY, GPL, ISC, LGPL, MIT, MIT/X11, MPL, Unknown, WTFPL)*
>
> Rajat Khandelwal wrote:
> Which one is unknown?
>
> Also, I think earlier versions of lgpl are not compatible with apache. Can you check wrt the actual version?
You can check http://www.apache.org/legal/resolved.html for compatability with apache license. With respect to the same, out of the licenses mentioned above Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, MIT, MIT/X11, ISC (licence is similar to BSD),
The following can be included (Category-B), some of these might require a mention in NOTICE (if they are getting bundled) : CC-BY (See http://www.apache.org/legal/resolved.html#cc-sa), MPL,
All versions of GPL and LGPL can not be included - see http://www.apache.org/legal/resolved.html#category-x.
After going through attached licenses.txt, I see that the only dependency with GPL and LGPL license is : tough-cookie@2.0.0 [license(s): BSD-3-Clause, GPL, LGPL, MPL]. The package is with more than one license and BSD-3-Clause and MPL are accepted licenses. Verified the same at https://www.npmjs.com/package/tough-cookie and https://github.com/SalesforceEng/tough-cookie/blob/master/LICENSE.
Not seeing any issue with dependency licenses.
Ankeet Maini, Can you please attach the licenses.txt at https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens. You can put a new section licensing with UI module and mention the same.
If we are planning to provide a convienient binary distribution for UI, we need to add appropriate LICENSE and NOTICE files with respect to above licenses listed.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95838
-----------------------------------------------------------
On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 6:45 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore d0fa424
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 19, 2015, 12:57 p.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 12
> > <https://reviews.apache.org/r/37530/diff/2/?file=1041996#file1041996line12>
> >
> > How are these dependencies downloaded?
> >
> > Can you also update license of each of the dependency here for us to check with apache compatibility.
>
> Ankeet Maini wrote:
> These dependencies are downloaded by npm (Node Package Manager). These are the licenses which the app uses *(LICENSES: Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, CC-BY, GPL, ISC, LGPL, MIT, MIT/X11, MPL, Unknown, WTFPL)*
Which one is unknown?
Also, I think earlier versions of lgpl are not compatible with apache. Can you check wrt the actual version?
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95838
-----------------------------------------------------------
On Aug. 20, 2015, 3:08 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2015, 3:08 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore d0fa424
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Aug. 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 12
> > <https://reviews.apache.org/r/37530/diff/2/?file=1041996#file1041996line12>
> >
> > How are these dependencies downloaded?
> >
> > Can you also update license of each of the dependency here for us to check with apache compatibility.
These dependencies are downloaded by npm (Node Package Manager). These are the licenses which the app uses *(LICENSES: Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, CC-BY, GPL, ISC, LGPL, MIT, MIT/X11, MPL, Unknown, WTFPL)*
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95838
-----------------------------------------------------------
On Aug. 19, 2015, 7:09 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 7:09 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> lens-ui/.gitignore PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Aug. 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 12
> > <https://reviews.apache.org/r/37530/diff/2/?file=1041996#file1041996line12>
> >
> > How are these dependencies downloaded?
> >
> > Can you also update license of each of the dependency here for us to check with apache compatibility.
>
> Ankeet Maini wrote:
> These dependencies are downloaded by npm (Node Package Manager). These are the licenses which the app uses *(LICENSES: Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, CC-BY, GPL, ISC, LGPL, MIT, MIT/X11, MPL, Unknown, WTFPL)*
>
> Rajat Khandelwal wrote:
> Which one is unknown?
>
> Also, I think earlier versions of lgpl are not compatible with apache. Can you check wrt the actual version?
>
> Amareshwari Sriramadasu wrote:
> You can check http://www.apache.org/legal/resolved.html for compatability with apache license. With respect to the same, out of the licenses mentioned above Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, MIT, MIT/X11, ISC (licence is similar to BSD),
>
> The following can be included (Category-B), some of these might require a mention in NOTICE (if they are getting bundled) : CC-BY (See http://www.apache.org/legal/resolved.html#cc-sa), MPL,
>
> All versions of GPL and LGPL can not be included - see http://www.apache.org/legal/resolved.html#category-x.
> After going through attached licenses.txt, I see that the only dependency with GPL and LGPL license is : tough-cookie@2.0.0 [license(s): BSD-3-Clause, GPL, LGPL, MPL]. The package is with more than one license and BSD-3-Clause and MPL are accepted licenses. Verified the same at https://www.npmjs.com/package/tough-cookie and https://github.com/SalesforceEng/tough-cookie/blob/master/LICENSE.
>
> Not seeing any issue with dependency licenses.
> Ankeet Maini, Can you please attach the licenses.txt at https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens. You can put a new section licensing with UI module and mention the same.
>
> If we are planning to provide a convienient binary distribution for UI, we need to add appropriate LICENSE and NOTICE files with respect to above licenses listed.
Requested access to edit, or someone with access can upload in the confluence. :)
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95838
-----------------------------------------------------------
On Sept. 17, 2015, 12:19 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 12:19 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> .gitignore 5a356e0
> lens-ui/LICENSE PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/pom.xml PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
> pom.xml adba544
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> File Attachments
> ----------------
>
> License details of NPM packages
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95838
-----------------------------------------------------------
lens-ui/package.json (line 12)
<https://reviews.apache.org/r/37530/#comment150991>
How are these dependencies downloaded?
Can you also update license of each of the dependency here for us to check with apache compatibility.
- Amareshwari Sriramadasu
On Aug. 19, 2015, 7:09 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 7:09 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> lens-ui/.gitignore PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by sharad agarwal <sh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95842
-----------------------------------------------------------
I tried the patch and could successfully bring the server up, pointed to my docker lens install with sample metastore. could do couple of queries from ui successfully.
- sharad agarwal
On Aug. 19, 2015, 7:09 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 7:09 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> lens-ui/.gitignore PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 19, 2015, 12:52 p.m., Rajat Khandelwal wrote:
> > All the javascript files should contain the apache license header. Since they are all server side files, we don't need to worry about increased network overhead due to increased javascript content.
>
> Ankeet Maini wrote:
> Actually, they are all client side, and the build process combines every file and generates a single **bundle.js** which will get bulky if we were to add these licsenses. I'll add if it's absolute necessary. Let me know!
Then the build process should minify all the js files. And in the process of minification, it should just retain one comment line about the license. Example being https://code.jquery.com/jquery-2.1.4.min.js
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95837
-----------------------------------------------------------
On Aug. 19, 2015, 12:39 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 12:39 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> lens-ui/.gitignore PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Ankeet Maini <an...@gmail.com>.
> On Aug. 19, 2015, 7:22 a.m., Rajat Khandelwal wrote:
> > All the javascript files should contain the apache license header. Since they are all server side files, we don't need to worry about increased network overhead due to increased javascript content.
Actually, they are all client side, and the build process combines every file and generates a single **bundle.js** which will get bulky if we were to add these licsenses. I'll add if it's absolute necessary. Let me know!
- Ankeet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95837
-----------------------------------------------------------
On Aug. 19, 2015, 7:09 a.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 7:09 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> lens-ui/.gitignore PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>
Re: Review Request 37530: LENS-629 - A new improved web client
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95837
-----------------------------------------------------------
All the javascript files should contain the apache license header. Since they are all server side files, we don't need to worry about increased network overhead due to increased javascript content.
- Rajat Khandelwal
On Aug. 19, 2015, 12:39 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 12:39 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat Khandelwal, sharad agarwal, and Yash Sharma.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-629 - A new improved web client
>
>
> Diffs
> -----
>
> lens-ui/.gitignore PRE-CREATION
> lens-ui/README.markdown PRE-CREATION
> lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION
> lens-ui/app/actions/LoginActions.js PRE-CREATION
> lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION
> lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION
> lens-ui/app/adapters/BaseAdapter.js PRE-CREATION
> lens-ui/app/app.js PRE-CREATION
> lens-ui/app/components/AboutComponent.js PRE-CREATION
> lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION
> lens-ui/app/components/AppComponent.js PRE-CREATION
> lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION
> lens-ui/app/components/CubeTreeComponent.js PRE-CREATION
> lens-ui/app/components/DatabaseComponent.js PRE-CREATION
> lens-ui/app/components/HeaderComponent.js PRE-CREATION
> lens-ui/app/components/LoaderComponent.js PRE-CREATION
> lens-ui/app/components/LoginComponent.js PRE-CREATION
> lens-ui/app/components/LogoutComponent.js PRE-CREATION
> lens-ui/app/components/QueryBoxComponent.js PRE-CREATION
> lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION
> lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION
> lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION
> lens-ui/app/components/QueryResultsComponent.js PRE-CREATION
> lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION
> lens-ui/app/components/SidebarComponent.js PRE-CREATION
> lens-ui/app/components/TableSchemaComponent.js PRE-CREATION
> lens-ui/app/components/TableTreeComponent.js PRE-CREATION
> lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION
> lens-ui/app/constants/AppConstants.js PRE-CREATION
> lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION
> lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION
> lens-ui/app/stores/CubeStore.js PRE-CREATION
> lens-ui/app/stores/DatabaseStore.js PRE-CREATION
> lens-ui/app/stores/TableStore.js PRE-CREATION
> lens-ui/app/stores/UserStore.js PRE-CREATION
> lens-ui/app/styles/css/global.css PRE-CREATION
> lens-ui/app/styles/css/login.css PRE-CREATION
> lens-ui/app/styles/css/query-component.css PRE-CREATION
> lens-ui/app/styles/css/tree.css PRE-CREATION
> lens-ui/app/styles/less/globals.less PRE-CREATION
> lens-ui/config.json PRE-CREATION
> lens-ui/index.html PRE-CREATION
> lens-ui/package.json PRE-CREATION
> lens-ui/server.js PRE-CREATION
> lens-ui/webpack.config.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37530/diff/
>
>
> Testing
> -------
>
> No server code added/modified. Just JavaScript!
>
>
> Thanks,
>
> Ankeet Maini
>
>