You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Tim Moore (JIRA)" <ji...@apache.org> on 2009/01/16 01:22:59 UTC
[jira] Created: (SHINDIG-871) Shindig's Java build script should
validate the correct Java version
Shindig's Java build script should validate the correct Java version
--------------------------------------------------------------------
Key: SHINDIG-871
URL: https://issues.apache.org/jira/browse/SHINDIG-871
Project: Shindig
Issue Type: Bug
Components: Common Components (Java), Gadget Rendering Server (Java), RESTful API (Java)
Affects Versions: trunk, 1.0.x-incubating
Reporter: Tim Moore
There have been a couple of cases where people checked in code that compiles under Java 6 but not Java 5.
The Maven enforcer plugin can be used to require a particular Java version or range.
http://maven.apache.org/plugins/maven-enforcer-plugin/rules/requireJavaVersion.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-871) Shindig's Java build script should
validate the correct Java version
Posted by "Tim Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664398#action_12664398 ]
Tim Moore commented on SHINDIG-871:
-----------------------------------
The attached patch was made against the 1.0.x-incubating branch, but it applies cleanly to trunk too.
> Shindig's Java build script should validate the correct Java version
> --------------------------------------------------------------------
>
> Key: SHINDIG-871
> URL: https://issues.apache.org/jira/browse/SHINDIG-871
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java), Gadget Rendering Server (Java), RESTful API (Java)
> Affects Versions: trunk, 1.0.x-incubating
> Reporter: Tim Moore
> Attachments: maven-enforcer-plugin-SHINDIG-871.patch
>
>
> There have been a couple of cases where people checked in code that compiles under Java 6 but not Java 5.
> The Maven enforcer plugin can be used to require a particular Java version or range.
> http://maven.apache.org/plugins/maven-enforcer-plugin/rules/requireJavaVersion.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-871) Shindig's Java build script should
validate the correct Java version
Posted by "Tim Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664773#action_12664773 ]
Tim Moore commented on SHINDIG-871:
-----------------------------------
Paul,
Your change allows building with Java 1.6, which is exactly what the original patch was trying to prevent in the first place! :-) I take it you were building with 1.6 and that's why it was failing on your system?
Per the discussion on shindig-dev[1] I think the only way to ensure that nobody commits changes that will break on 1.5 is to force all builds to be made with that version.
[1] http://markmail.org/message/oy7k4xq7n2xqttjg
> Shindig's Java build script should validate the correct Java version
> --------------------------------------------------------------------
>
> Key: SHINDIG-871
> URL: https://issues.apache.org/jira/browse/SHINDIG-871
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java), Gadget Rendering Server (Java), RESTful API (Java)
> Affects Versions: trunk, 1.0.x-incubating
> Reporter: Tim Moore
> Attachments: maven-enforcer-plugin-SHINDIG-871.patch
>
>
> There have been a couple of cases where people checked in code that compiles under Java 6 but not Java 5.
> The Maven enforcer plugin can be used to require a particular Java version or range.
> http://maven.apache.org/plugins/maven-enforcer-plugin/rules/requireJavaVersion.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-871) Shindig's Java build script should
validate the correct Java version
Posted by "Tim Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moore updated SHINDIG-871:
------------------------------
Issue Type: Improvement (was: Bug)
> Shindig's Java build script should validate the correct Java version
> --------------------------------------------------------------------
>
> Key: SHINDIG-871
> URL: https://issues.apache.org/jira/browse/SHINDIG-871
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java), Gadget Rendering Server (Java), RESTful API (Java)
> Affects Versions: trunk, 1.0.x-incubating
> Reporter: Tim Moore
>
> There have been a couple of cases where people checked in code that compiles under Java 6 but not Java 5.
> The Maven enforcer plugin can be used to require a particular Java version or range.
> http://maven.apache.org/plugins/maven-enforcer-plugin/rules/requireJavaVersion.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-871) Shindig's Java build script should
validate the correct Java version
Posted by "Tim Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moore updated SHINDIG-871:
------------------------------
Attachment: maven-enforcer-plugin-SHINDIG-871.patch
Patch attached. For simplicity's sake, I put the plugin execution in the top-level POM so it will execute for all sub-modules. Technically this is only really important for java submodules so if you prefer you could move the second plugin declaration into java/pom.xml instead.
> Shindig's Java build script should validate the correct Java version
> --------------------------------------------------------------------
>
> Key: SHINDIG-871
> URL: https://issues.apache.org/jira/browse/SHINDIG-871
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java), Gadget Rendering Server (Java), RESTful API (Java)
> Affects Versions: trunk, 1.0.x-incubating
> Reporter: Tim Moore
> Attachments: maven-enforcer-plugin-SHINDIG-871.patch
>
>
> There have been a couple of cases where people checked in code that compiles under Java 6 but not Java 5.
> The Maven enforcer plugin can be used to require a particular Java version or range.
> http://maven.apache.org/plugins/maven-enforcer-plugin/rules/requireJavaVersion.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-871) Shindig's Java build script should
validate the correct Java version
Posted by "Vincent Siveton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton resolved SHINDIG-871.
-------------------------------------
Resolution: Fixed
Fix Version/s: trunk
Assignee: Paul Lindner
Fixed in [r735053|http://svn.apache.org/viewvc?rev=735053&view=rev]
> Shindig's Java build script should validate the correct Java version
> --------------------------------------------------------------------
>
> Key: SHINDIG-871
> URL: https://issues.apache.org/jira/browse/SHINDIG-871
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk, 1.0.x-incubating
> Reporter: Tim Moore
> Assignee: Paul Lindner
> Fix For: trunk
>
> Attachments: maven-enforcer-plugin-SHINDIG-871.patch
>
>
> There have been a couple of cases where people checked in code that compiles under Java 6 but not Java 5.
> The Maven enforcer plugin can be used to require a particular Java version or range.
> http://maven.apache.org/plugins/maven-enforcer-plugin/rules/requireJavaVersion.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-871) Shindig's Java build script should
validate the correct Java version
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664560#action_12664560 ]
Paul Lindner commented on SHINDIG-871:
--------------------------------------
Hi Tim,
I had to modify the patch a little bit to work on my system.
mvn enforcer:enforce was failing
Could you please validate this change? I'm also going to let it get picked up by hudson and we'll see how it runs there. Once that's done then we'll push this into 1.0.x
Thanks!
> Shindig's Java build script should validate the correct Java version
> --------------------------------------------------------------------
>
> Key: SHINDIG-871
> URL: https://issues.apache.org/jira/browse/SHINDIG-871
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java), Gadget Rendering Server (Java), RESTful API (Java)
> Affects Versions: trunk, 1.0.x-incubating
> Reporter: Tim Moore
> Attachments: maven-enforcer-plugin-SHINDIG-871.patch
>
>
> There have been a couple of cases where people checked in code that compiles under Java 6 but not Java 5.
> The Maven enforcer plugin can be used to require a particular Java version or range.
> http://maven.apache.org/plugins/maven-enforcer-plugin/rules/requireJavaVersion.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.