You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ns...@apache.org on 2011/10/11 04:12:04 UTC

svn commit: r1181479 - /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java

Author: nspiegelberg
Date: Tue Oct 11 02:12:04 2011
New Revision: 1181479

URL: http://svn.apache.org/viewvc?rev=1181479&view=rev
Log:
add instrumentation for debugging Snapshot MR generation failures

Summary:
add instrumentation for debugging Snapshot MR generation failures

Test Plan:
* ran MR based export utility to verify the debug statements on dev cluster.

* ran bin/hbase verify on dev cluster.

DiffCamp Revision: 202270
Reviewed By: aravind
Reviewers: nspiegelberg, aravind
CC: liujiakai, aravind
Revert Plan:
OK

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java?rev=1181479&r1=1181478&r2=1181479&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java Tue Oct 11 02:12:04 2011
@@ -28,6 +28,7 @@ import org.apache.hadoop.hbase.client.Re
 import org.apache.hadoop.hbase.client.ResultScanner;
 import org.apache.hadoop.hbase.client.Scan;
 import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
+import org.apache.hadoop.hbase.util.Bytes;
 import org.apache.hadoop.util.StringUtils;
 
 /**
@@ -64,6 +65,9 @@ public class TableRecordReaderImpl {
    * @throws IOException When restarting the scan fails.
    */
   public void init() throws IOException {
+    LOG.info("Scanner init ; " +
+             " start row = " + Bytes.toStringBinary(scan.getStartRow()) +
+             " stop row = " + Bytes.toStringBinary(scan.getStopRow()));
     restart(scan.getStartRow());
   }
 
@@ -131,7 +135,7 @@ public class TableRecordReaderImpl {
     try {
       value = this.scanner.next();
     } catch (IOException e) {
-      LOG.debug("recovered from " + StringUtils.stringifyException(e));
+      LOG.info("recovered from " + StringUtils.stringifyException(e));
       restart(lastRow);
       scanner.next();    // skip presumed already mapped row
       value = scanner.next();