[jira] [Work logged] (BEAM-6165) Send metrics to Flink in portable Flink runner

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-6165?focusedWorklogId=180889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180889 ]

ASF GitHub Bot logged work on BEAM-6165:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jan/19 22:49
            Start Date: 03/Jan/19 22:49
    Worklog Time Spent: 10m 
      Work Description: ryan-williams commented on pull request #7183: [BEAM-6165] send metrics to Flink in portable Flink runner
URL: https://github.com/apache/beam/pull/7183#discussion_r245158798
 
 

 ##########
 File path: runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/FlinkMetricContainer.java
 ##########
 @@ -77,12 +82,72 @@ public FlinkMetricContainer(RuntimeContext runtimeContext) {
     this.metricsAccumulator = (MetricsAccumulator) metricsAccumulator;
   }
 
-  MetricsContainer getMetricsContainer(String stepName) {
+  public MetricsContainer getMetricsContainer(String stepName) {
     return metricsAccumulator != null
         ? metricsAccumulator.getLocalValue().getContainer(stepName)
         : null;
   }
 
+  /**
+   * Parse a {@link MetricName} from a {@link
+   * org.apache.beam.model.fnexecution.v1.BeamFnApi.MonitoringInfoUrns.Enum}
+   *
+   * <p>Should be consistent with {@code parse_namespace_and_name} in monitoring_infos.py
+   *
+   * <p>TODO: not flink-specific; where should it live?
+   */
+  public static MetricName parseUrn(String urn) {
+    if (urn.startsWith(USER_COUNTER_URN_PREFIX.toString())) {
 
 Review comment:
   good catch, thanks! I just filed #7408 to fix
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 180889)
    Time Spent: 6h 50m  (was: 6h 40m)

> Send metrics to Flink in portable Flink runner
> ----------------------------------------------
>
>                 Key: BEAM-6165
>                 URL: https://issues.apache.org/jira/browse/BEAM-6165
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>    Affects Versions: 2.8.0
>            Reporter: Ryan Williams
>            Assignee: Ryan Williams
>            Priority: Major
>              Labels: metrics, portability, portability-flink
>             Fix For: 2.10.0
>
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> Metrics are sent from the fn harness to runner in the Python SDK (and likely Java soon), but the portable Flink runner doesn't pass them on to Flink, which it should, so that users can see them in e.g. the Flink UI or via any Flink metrics reporters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)