[jira] [Commented] (TINKERPOP-1854) Support lambdas in Gremlin.Net

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399217#comment-16399217 ] 

ASF GitHub Bot commented on TINKERPOP-1854:
-------------------------------------------

Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/792
  
    I just rebased on `tp32` and hopefully also addressed your suggestions. `Lambda` now implements a bunch of interfaces that mirror the Java functional interfaces from the traversal API:
    ```cs
    public class Lambda : IFunction, IBiFunction, IPredicate, IUnaryOperator, IBinaryOperator,
            IComparator, IConsumer, ISupplier
    ```
    This should make it easier for users to see where lambdas can be used. I also added a short note to the documentation about these interfaces for lambdas.
    
    With all these new interfaces there is now just one Java type left for which we don't have a .NET equivalent: `VertexProgram`. So the next release will again increase type-safety of the traversal API a lot.
    
    We are now down to just 5 ignored scenarios for `tp32` 🎉
    
    @jorgebay, you linked the Java `Lambda` interface in one of your comments. The same file also contains classes like `TwoArgLambda` that are very similar to the `Lambda` class I implemented in this PR, but they use [different methods for the different interfaces](https://github.com/apache/tinkerpop/blob/3.2.7/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/function/Lambda.java#L158) like:
    ```java
    public static <A> Consumer<A> consumer(final String lambdaSource,
            final String lambdaLanguage)
    ```
    Do we also want to have similar methods in Gremlin.Net? It would be very easy to implement and I can image that just having a `Lambda` object could lead to some confusion as to where it can be used.


> Support lambdas in Gremlin.Net
> ------------------------------
>
>                 Key: TINKERPOP-1854
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1854
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.3.0, 3.2.6
>            Reporter: Florian Hockmann
>            Assignee: Florian Hockmann
>            Priority: Major
>             Fix For: 3.2.8, 3.3.2
>
>
> Gremlin.Net should support lambdas. We already discussed this in [the pull request for TINKERPOP-1752|https://github.com/apache/tinkerpop/pull/712]. Here is what [~spmallette] said over there:
> {quote}
> Any reason we don't support lambdas? Even if .NET can't support them natively for some reason wouldn't we minimally support the ability to pass a python/groovy/etc lambda? it's kinda weird that way, but i think back to the point that kuppitz made on the dev list the other day where he stated that he doesn't always find a way out of using lambdas in production systems he works on - so ultimately users will need that kind of capability i think.
> {quote}
> C# lambdas would require some kind of C# parser on the server side, so at least in the beginning a way to send lambdas from already supported languages in Gremlin.Net should be enough.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)